Conversation
c8451dd to
0da1861
Compare
0d3dfe8 to
5b43ea1
Compare
|
I am not sure what the overall decision about different versioning for Inference Extension and Gateway API, but it looks like this change will use same version for both packages? |
|
It is more of a nit than anything else... |
Ohh, we meant to have different release version for rust API. Sorry, I did not get that. I was under impression for different version of upstream CRDs. Should we start a new versioning like |
5b43ea1 to
23d73f1
Compare
Agree, i missed it. |
I think we need @shaneutt to make a call here. I have seen that some projects would use custom versioning. In this case for example 0.19+1.2.1 for inference-extension-api and 0.19-1.4 for gateway-api, would have all the information necessary. |
|
I'm open to the suggestion of doing a version tag that tracks the upstream version. We can always have a couple of tags if needed. |
23d73f1 to
68142c3
Compare
shaneutt
left a comment
There was a problem hiding this comment.
Thanks @nitishkumar71!
Took a quick high-level review pass, and added a couple of comments. Also needs some updates to make CI happy.
Did you run into much trouble while working on this, or did it seem pretty straightforward?
388e4b8 to
eccb23c
Compare
It took me sometime but delay was mostly due to some other personal things at my end. |
There was a problem hiding this comment.
There's definitely a few things we could continue to tweak here, but most of that is reasonable to tweak in upcoming iterations, so I think we're mostly ready to go.
There are a couple things in the new script for safety we need to do now, and can't wait for future iterations, which I've added comments for.
After those are resolved, I think we're good to go and we can continue moving this forward with some smaller incremental PRs from here.
Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> seperate generators for gateway api and extensions Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
0ce626b to
97a5917
Compare
Thanks for pointing them out, changes are done |
@shaneutt what were the additional things you were planning to tweak here? I can pick them up |
PR is still in development phase and purpose of this PR is just to show the approach we are taking in to support inference extension. Few things which are still need to be implented here areexperimental API support for inference extension which is not working right now due to errorError: CRD '' has no versionsin versionv1.0.2Inference extension will published as separate create which is not done yetTestsPR adds support of the inference extension as independent crate which will add CRDs support based on upstream version. It's possible there will be some duplicate code between
gateway-apiandinference extension, which is accepted approach for now. There is also some code duplication in test code, which should be handled when more extension support is being added.Supporting issue #175