fix: build the mc status correctly#385
Open
zhiying-lin wants to merge 4 commits intokubefleet-dev:mainfrom
Open
fix: build the mc status correctly#385zhiying-lin wants to merge 4 commits intokubefleet-dev:mainfrom
zhiying-lin wants to merge 4 commits intokubefleet-dev:mainfrom
Conversation
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
copy latest imc status when the observedGeneration is matched with the imc generation.
After the fix,
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
unit tests + e2e tests
Special notes for your reviewer