Skip to content

fix: build the mc status correctly#385

Open
zhiying-lin wants to merge 4 commits intokubefleet-dev:mainfrom
zhiying-lin:fix-mc
Open

fix: build the mc status correctly#385
zhiying-lin wants to merge 4 commits intokubefleet-dev:mainfrom
zhiying-lin:fix-mc

Conversation

@zhiying-lin
Copy link
Collaborator

@zhiying-lin zhiying-lin commented Dec 18, 2025

Description of your changes

copy latest imc status when the observedGeneration is matched with the imc generation.

After the fix,

  1. MC gen : 2, IMC. gen 1, IMC condition gen 1
  2. After copy, IMC gen 2 and send update IMC request to api server, IMC gen 2 in the memory
  3. IMC gen != IMC condition
  4. copy IMC status -> MC, stale info, do nothing
  5. set MC condition gen 2 -> unknown
  6. when imc collects the status gen 2 back, set MC condition gen 2 -> joined

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

unit tests + e2e tests

Special notes for your reviewer

Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
@zhiying-lin zhiying-lin marked this pull request as draft December 18, 2025 02:53
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../membercluster/v1beta1/membercluster_controller.go 96.77% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
@zhiying-lin zhiying-lin marked this pull request as ready for review December 23, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant