frontend : lib : fix decimal CPU quantity formatting in normalizeUnit by AarishMansur · Pull Request #6444 · kubernetes-sigs/headlamp

AarishMansur · 2026-07-09T06:35:44Z

Summary

This PR fixes a formatting bug in normalizeUnit where CPU quantities passed as decimal strings (e.g. "2.0") were displayed as "2.0 cores" instead of "2 cores", the current change trims trailing decimal zeros via regex replacement

Related Issue

Fixes #6443

Changes

Fixed fallback branch in normalizeUnit (frontend/src/lib/util.ts) to wrap quantity in Number(), normalizing decimal strings like "2.0" to whole numbers before appending the unit label.

Steps to Test

Call normalizeUnit('cpu', '2.0') in a local test script or unit test.
Observe the return value is now "2 cores" instead of "2.0 cores".
Verify existing cases are unaffected: "1000m" → "1 core", "1" → "1 core", "2000m" → "2 cores".

Screenshots (if applicable)

N/A this is a pure logic fix with no UI changes.

Notes for the Reviewer

The change is a single line fix in the CPU case of normalizeUnit.
"2000" (no suffix) is not a valid Kubernetes CPU input, so no handling was added for that case.

linux-foundation-easycla · 2026-07-09T06:35:52Z

The committers listed above are authorized under a signed CLA.

✅ login: AarishMansur / name: aarish mansur (bb2d572)

kubernetes-prow · 2026-07-09T06:35:53Z

Welcome @AarishMansur!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

kubernetes-prow · 2026-07-09T06:35:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AarishMansur
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

illume

Thanks for working on this.

The commit messages could use some tidying up to match our contribution guidelines. We use Linux kernel style — the contributing guide has the details, and git log shows good examples.

Commits that need attention

frontend : lib : fix decimal CPU quantity formatting in normalizeUnit — Missing area: description prefix — e.g. frontend: HomeButton: Fix so it navigates to home or backend: config: Add enable-dynamic-clusters flag.

Commit guidelines

Use atomic commits focused on a single change.
Use the title format <area>: <Description of changes> — description must start with a capital letter.
Keep the title under 72 characters (soft requirement).
Explain the intention and why the change is needed.
Make commit titles meaningful and describe what changed.
Do not add code that a later commit rewrites; squash or reorder commits instead.
Do not include Fixes #NN in commit messages.

Good examples:

frontend: HomeButton: Fix so it navigates to home
backend: config: Add enable-dynamic-clusters flag

Copilot

Pull request overview

This PR aims to fix CPU quantity display in normalizeUnit so decimal core strings like "2.0" render as "2 cores" rather than "2.0 cores".

Changes:

Updates the CPU fallback formatting path in normalizeUnit to coerce decimal strings via Number(...) before stringification.

Note: CI/check status and PR commit history are not available in the provided review context—please confirm CI is green and the PR history is linear (no merge commits in the PR range).

AarishMansur · 2026-07-10T13:06:55Z

@illume I've updated the commit messages to follow the Linux kernel style and addressed the Copilot suggestions as well. Could you please take another look when you have some time? Thanks!

illume

Thanks for the contribution.

it looks like there's a merge-main commit in this PR — could you rebase onto main instead?

Why this matters

Merge commits from main make the PR history harder to review. Please rebase your branch on top of the latest main instead, then update the PR with the rebased commits.

Could you take a look at the commit messages in this PR? We follow a Linux kernel style for git commits — see the contributing guide and git log for examples.

Commits that need attention

frontend : lib : fix decimal CPU quantity formatting in normalizeUnit — Missing area: description prefix — e.g. frontend: HomeButton: Fix so it navigates to home or backend: config: Add enable-dynamic-clusters flag.
frontend : lib : Added test to cover Normalize unit — Missing area: description prefix — e.g. frontend: HomeButton: Fix so it navigates to home or backend: config: Add enable-dynamic-clusters flag.

Commit guidelines

Use atomic commits focused on a single change.
Use the title format <area>: <Description of changes> — description must start with a capital letter.
Keep the title under 72 characters (soft requirement).
Explain the intention and why the change is needed.
Make commit titles meaningful and describe what changed.
Do not add code that a later commit rewrites; squash or reorder commits instead.
Do not include Fixes #NN in commit messages.

Good examples:

frontend: HomeButton: Fix so it navigates to home
backend: config: Add enable-dynamic-clusters flag

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

…malizeUnit

AarishMansur · 2026-07-10T15:00:19Z

@illume Done I've rebased the branch and updated the commit messages to follow the project's commit message style.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

    case 'cpu':
      normalizedQuantity = quantity?.endsWith('m')
        ? `${Number(quantity.substring(0, quantity.length - 1)) / 1000}`
-        : `${quantity}`;
+        : `${(quantity ?? '').replace(/(\.\d*?)0+$/, '$1').replace(/\.$/, '')}`;
      if (normalizedQuantity === '1') {


kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2026

kubernetes-prow Bot requested review from illume and sniok July 9, 2026 06:35

kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 9, 2026

illume requested a review from Copilot July 10, 2026 05:14

illume requested changes Jul 10, 2026

View reviewed changes

Copilot started reviewing on behalf of illume July 10, 2026 05:14 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread frontend/src/lib/util.ts Outdated

Comment thread frontend/src/lib/util.ts Outdated

kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2026

AarishMansur force-pushed the fix/decimal-formatting branch from 1072701 to d923b23 Compare July 10, 2026 12:59

illume requested a review from Copilot July 10, 2026 14:21

illume requested changes Jul 10, 2026

View reviewed changes

Copilot started reviewing on behalf of illume July 10, 2026 14:21 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread frontend/src/lib/util.ts

AarishMansur added 2 commits July 10, 2026 20:21

frontend : normalizeUnit : Fix decimal CPU quantity formatting in nor…

214da64

…malizeUnit

frontend : normalizeUnit : Add test for decimal CPU quantity formatting

c33832d

AarishMansur force-pushed the fix/decimal-formatting branch from 271ec43 to c33832d Compare July 10, 2026 14:58

illume requested a review from Copilot July 13, 2026 07:18

Copilot started reviewing on behalf of illume July 13, 2026 07:18 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

frontend : lib : fix decimal CPU quantity formatting in normalizeUnit#6444

frontend : lib : fix decimal CPU quantity formatting in normalizeUnit#6444
AarishMansur wants to merge 2 commits into
kubernetes-sigs:mainfrom
AarishMansur:fix/decimal-formatting

AarishMansur commented Jul 9, 2026 •

edited

Loading

Uh oh!

linux-foundation-easycla Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

kubernetes-prow Bot commented Jul 9, 2026

Uh oh!

kubernetes-prow Bot commented Jul 9, 2026

Uh oh!

illume left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

AarishMansur commented Jul 10, 2026

Uh oh!

illume left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

AarishMansur commented Jul 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

AarishMansur commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Changes

Steps to Test

Screenshots (if applicable)

Notes for the Reviewer

Uh oh!

linux-foundation-easycla Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubernetes-prow Bot commented Jul 9, 2026

Uh oh!

kubernetes-prow Bot commented Jul 9, 2026

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

AarishMansur commented Jul 10, 2026

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

AarishMansur commented Jul 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AarishMansur commented Jul 9, 2026 •

edited

Loading

linux-foundation-easycla Bot commented Jul 9, 2026 •

edited

Loading