frontend: secret: add unit tests for details and list views#6451
Open
Rucha0901 wants to merge 1 commit into
Open
frontend: secret: add unit tests for details and list views#6451Rucha0901 wants to merge 1 commit into
Rucha0901 wants to merge 1 commit into
Conversation
kubernetes-prow
Bot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Rucha0901 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
size/L
illume
requested changes
Jul 10, 2026
illume
left a comment
illume
left a comment
Contributor
There was a problem hiding this comment.
Thanks for these changes.
Can you please have a look at the git commits to see if they meet the contribution guidelines? We use a Linux kernel style of git commits. See the contributing guide for general context, and please see previous git commits with git log for examples.
Commits that need attention
frontend: secret: add unit tests for details and list views— Description must start with a capital letter — e.g.frontend: HomeButton: Fix the buttonnotfrontend: HomeButton: fix the button.
Commit guidelines
- Use atomic commits focused on a single change.
- Use the title format
<area>: <Description of changes>— description must start with a capital letter. - Keep the title under 72 characters (soft requirement).
- Explain the intention and why the change is needed.
- Make commit titles meaningful and describe what changed.
- Do not add code that a later commit rewrites; squash or reorder commits instead.
- Do not include
Fixes #NNin commit messages.
Good examples:
frontend: HomeButton: Fix so it navigates to homebackend: config: Add enable-dynamic-clusters flag
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Vitest unit tests for the Secret UI “component family” to improve regression coverage for the Secrets list and details views (per issue #6450).
Changes:
- Added a
SecretListunit test that verifies the column set and custom column value mapping. - Added a
SecretDetailsunit test that verifiesDetailsGridprops,extraInfocontent, andextraSectionswiring.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/components/secret/List.test.tsx | Adds unit tests around SecretList column definitions and custom column value mapping. |
| frontend/src/components/secret/Details.test.tsx | Adds unit tests around SecretDetails DetailsGrid props plus extraInfo / extraSections behavior. |
Comment on lines
+65
to
+69
| const props = mockDetailsGrid.mock.calls[0][0]; | ||
| const extraInfo = props.extraInfo(BASE_SECRET); | ||
| const byName = Object.fromEntries(extraInfo.map((f: any) => [f.name, f.value])); | ||
|
|
||
| expect(byName['translation|Type']).toBe('test'); |
Comment on lines
+74
to
+75
| expect(typeCol.getValue(BASE_SECRET)).toBe('test'); | ||
| expect(dataCol.getValue(BASE_SECRET)).toBe(3); // storageClassName, volumeMode, volumeName |
kubernetes-prow
Bot
added
the
do-not-merge/work-in-progress
Member
|
@Rucha0901 the CI is failing, can you take a look |
Contributor
Author
|
@ashu8912 Give me some time, I will fix it. |
Rucha0901
force-pushed
the
fix/add-secret-unit-tests
branch
from
fceaac3 to
418e091
Compare
kubernetes-prow
Bot
removed
the
do-not-merge/work-in-progress
Add Vitest unit tests for SecretDetails and SecretList component views to improve regression coverage for the secret component family. Specifically: - Assert that SecretDetails sets DetailsGrid props (withEvents). - Assert the returned extraInfo array shape and values directly. - Assert extraSections rendering the SecretDataSection. - Assert SecretList column definitions and dynamically verify the mapped data count using the length of the secret keys. Signed-off-by: Rucha0901 <imt_2025071@iiitm.ac.in>
Rucha0901
force-pushed
the
fix/add-secret-unit-tests
branch
from
418e091 to
0686d9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds unit tests for the
SecretListandSecretDetailscomponents under thesecretcomponent family.Related Issue
Fixes #6450
Changes
Steps to Test
frontend/directory.npm run test -- secret