backend: kubeconfig: Fix node drain anonymous auth in OIDC deployments#6460
Open
srajang1805 wants to merge 1 commit into
Open
backend: kubeconfig: Fix node drain anonymous auth in OIDC deployments#6460srajang1805 wants to merge 1 commit into
srajang1805 wants to merge 1 commit into
Conversation
…OIDC deployments Set the in-cluster service account token file path on the AuthInfo even when unsafeUseServiceAccountToken is disabled. Previously the TokenFile was left empty, causing backend-initiated operations like node drain to use a clientset with no credentials when no user token was available, authenticating as system:anonymous. The unsafe flag now controls which token file path is used (custom vs. default), while the token file is always present as a credential fallback for the RESTConfig. Also strip the Bearer prefix from tokens in ClientSetWithToken to prevent duplicate prefixes in the Authorization header. Ref: kubernetes-sigs#5110
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: srajang1805 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
cncf-cla: yes
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5110 — node drain operations fail with
system:anonymousinin-cluster OIDC deployments because the in-cluster context's AuthInfo
had no token file when
unsafeUseServiceAccountTokenwas disabled.Root cause
getInClusterContextatkubeconfig.go:1114set the service accounttoken file only when
unsafeUseServiceAccountTokenwas true. Withoutthis flag,
TokenFilewas left empty. Backend-initiated operationslike node drain (which don't go through the user-token reverse proxy)
used a clientset with no credentials, authenticating as
system:anonymous.A secondary issue:
ClientSetWithTokensetrestConf.BearerTokendirectly without stripping the
Bearerprefix, which could cause aduplicate-prefix
Authorizationheader if a caller passed it.Changes
backend/pkg/kubeconfig/kubeconfig.go: Always set the in-clusterAuthInfo.TokenFilefromclusterConfig.BearerTokenFile. Theunsafeflag now controls which path (custom vs. default), notwhether a path is set at all.
backend/pkg/kubeconfig/kubeconfig.go: StripBearerprefix inClientSetWithTokenbefore settingrestConf.BearerToken.backend/pkg/kubeconfig/service_account_token_test.go: Update testto expect the token file is preserved when unsafe is disabled.
Testing