feat: add Minio/S3 test sources support for Testworkflows#6896
Open
dhimanAbhi wants to merge 1 commit intokubeshop:mainfrom
Open
feat: add Minio/S3 test sources support for Testworkflows#6896dhimanAbhi wants to merge 1 commit intokubeshop:mainfrom
dhimanAbhi wants to merge 1 commit intokubeshop:mainfrom
Conversation
Signed-off-by: Abhishek Dhiman <abhi2002dhiman@gmail.com>
Collaborator
|
@greptile |
Contributor
Greptile SummaryThis PR adds MinIO/S3 support as a content source for TestWorkflows, enabling test content distribution in air-gapped or restricted environments without Git access. The implementation follows the existing pattern used for Git-based content sources. Key Changes:
Critical Issue Found:
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant TestWorkflow
participant Processor
participant Toolkit
participant MinIO
User->>TestWorkflow: Define workflow with content.minio
TestWorkflow->>Processor: ProcessContentMinio()
Processor->>Processor: Parse endpoint, bucket, path, region
Processor->>Processor: Handle credentials (plain or from secret)
Processor->>Toolkit: Create minio command container
Toolkit->>MinIO: Connect to endpoint with credentials
MinIO-->>Toolkit: List bucket contents
Toolkit->>Toolkit: Download files to /data/minio
Toolkit->>Toolkit: Adjust file permissions
Toolkit-->>TestWorkflow: Files available at mountPath
TestWorkflow->>User: Execute test steps with downloaded content
Last reviewed commit: 73a91e0 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+497
to
+507
| func MapContentMinioKubeToAPI(v testworkflowsv1.ContentMinio) testkube.TestWorkflowContentMinio { | ||
| return testkube.TestWorkflowContentMinio{ | ||
| Endpoint: v.Endpoint, | ||
| Bucket: v.Bucket, | ||
| Path: v.Path, | ||
| AccessKey: v.AccessKey, | ||
| SecretKey: v.SecretKey, | ||
| AccessKeyFrom: common.MapPtr(v.AccessKeyFrom, MapEnvVarSourceKubeToAPI), | ||
| SecretKeyFrom: common.MapPtr(v.SecretKeyFrom, MapEnvVarSourceKubeToAPI), | ||
| MountPath: v.MountPath, | ||
| } |
Contributor
There was a problem hiding this comment.
missing Region field in mapper - will break region-based S3 bucket access
The Region field is defined in the ContentMinio struct (line 65 in api/testworkflows/v1/content_types.go) and used in operations.go (line 312), but is not being mapped here. Add Region: v.Region, after the Path field on line 501.
Comment on lines
+321
to
+331
| func MapContentMinioAPIToKube(v testkube.TestWorkflowContentMinio) testworkflowsv1.ContentMinio { | ||
| return testworkflowsv1.ContentMinio{ | ||
| Endpoint: v.Endpoint, | ||
| Bucket: v.Bucket, | ||
| Path: v.Path, | ||
| AccessKey: v.AccessKey, | ||
| SecretKey: v.SecretKey, | ||
| AccessKeyFrom: common.MapPtr(v.AccessKeyFrom, MapEnvVarSourceAPIToKube), | ||
| SecretKeyFrom: common.MapPtr(v.SecretKeyFrom, MapEnvVarSourceAPIToKube), | ||
| MountPath: v.MountPath, | ||
| } |
Contributor
There was a problem hiding this comment.
missing Region field in mapper - will break region-based S3 bucket access
The Region field is defined in the ContentMinio struct and used in processing logic, but is not being mapped here. Add Region: v.Region, after the Path field on line 325.
vsukhin
requested changes
Feb 20, 2026
Collaborator
vsukhin
left a comment
vsukhin
left a comment
There was a problem hiding this comment.
hey @dhimanAbhi thank you for your contribution. please check feedback. btw, did you test it poeprly on your side?
Member
|
@dhimanAbhi please address review issues - would love to get this in 🙏 |
Contributor
Author
|
Hi @olensmar, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
This PR introduces support for MinIO/S3-based test sources in Testworkflows. It enables fetching test assets directly from MinIO or any S3-compatible object storage as an alternative to Git-based sources. This addition provides a reliable way to distribute test content in environments with no Git access , such as restricted, air-gapped, or production Kubernetes clusters where cloning repositories is not allowed. This PR solves #4270 and #4465
Testworkflow Definition
Users can now define a MinIO/S3-based test source by specifying:
Template
Example
Proof Manifests
These logs are from a TestWorkflow executed locally. I configured a local MinIO instance and uploaded the Cypress test suite located at
testkube/test/cypress/cypress-12from the Testkube repository. This TestWorkflow successfully fetches the test content from the MinIO bucket in the same way Testkube currently fetches content from Git-based sources.Checklist (choose whats happened)
Breaking changes
Changes
Fixes