Add e2e test for Perses dashboards deployment #3943
Conversation
kubevirt-bot
added
release-note-none
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @sradco, your pull request is larger than the review limit of 150000 diff characters
Pull Request Test Coverage Report for Build 21205982802Details
💛 - Coveralls |
|
@nunnatsa Hi, Please review this PR. Thank you |
| defer f.Close() | ||
|
|
||
| dec := yaml.NewYAMLOrJSONDecoder(f, 4096) | ||
| for { |
There was a problem hiding this comment.
why do we need a loop here? it's single file.
sradco
force-pushed
the
add_e2e_tests_for_perses_crs_deployment
branch
from
cb285e5 to
e523265
Compare
sradco
changed the title
sradco
force-pushed
the
add_e2e_tests_for_perses_crs_deployment
branch
from
e523265 to
c1cde70
Compare
sradco
force-pushed
the
add_e2e_tests_for_perses_crs_deployment
branch
3 times, most recently
from
6cd8575 to
d4bac49
Compare
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-operator-sdk-gcp, hco-e2e-operator-sdk-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-consecutive-operator-sdk-upgrades-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
nunnatsa
left a comment
nunnatsa
left a comment
There was a problem hiding this comment.
Added some more comments inline.
sradco
force-pushed
the
add_e2e_tests_for_perses_crs_deployment
branch
from
b30274b to
fa7a235
Compare
sradco
force-pushed
the
add_e2e_tests_for_perses_crs_deployment
branch
from
fa7a235 to
7a35e3e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sradco
force-pushed
the
add_e2e_tests_for_perses_crs_deployment
branch
from
7a35e3e to
d11443b
Compare
|
New changes are detected. LGTM label has been removed. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sradco
force-pushed
the
add_e2e_tests_for_perses_crs_deployment
branch
from
d11443b to
e757a9b
Compare
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR fixes the logic of when we deploy the Perses dashboards and datasource and add e2e test for checking they are deplyed only when the perses CRD exists. Signed-off-by: Shirly Radco <[email protected]>
sradco
force-pushed
the
add_e2e_tests_for_perses_crs_deployment
branch
from
e757a9b to
a57d07d
Compare
|
|
|
||
| // Skip registration cleanly when Perses CRDs are not installed (e.g., unit/CI envs) | ||
| if !checkPersesAvailable(context.Background(), mgr.GetClient()) { | ||
| available := checkPersesAvailable(ctx, mgr.GetClient()) |
There was a problem hiding this comment.
At this phase, the mgr.Client cache is not populate yet. You'll need to use the apiClient from main (pass it as a parameter to SetupPersesWithManager; e.g.
func SetupPersesWithManager(ctx context.Context, uncachedClient client.Client, mgr manager.Manager, ownerRef metav1.OwnerReference) error {And in main:
if err = perses.SetupPersesWithManager(ctx, apiClient, mgr, ownresources.GetDeploymentRef()); err != nil {then use it here:
| available := checkPersesAvailable(ctx, mgr.GetClient()) | |
| available := checkPersesAvailable(ctx, uncachedClient) |
| DeferCleanup(func(ctx context.Context) { | ||
| tests.DumpHCOPodLogs(ctx, "after perses dynamic CRD gating", tests.LogCaptureOptions{Since: &testStart, IncludePrevious: true}) | ||
| }) |
There was a problem hiding this comment.
there are now two DeferCleanups not sure it's working. Anyway - there is no "after perses dynamic CRD gating" lines in the test log; e.g. here: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/kubevirt_hyperconverged-cluster-operator/3943/pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-gcp/2013920845403000832/artifacts/hco-e2e-operator-sdk-gcp/e2e-test/build-log.txt
There was a problem hiding this comment.
Maybe you should move this code into the other DeferCleanup call.
|
@sradco: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
What this PR does / why we need it:
This PR adds e2e test for Perses dashboards and datasource
deployment.
It checks that they will be deployed only when the CRDs exist.
Reviewer Checklist
Jira Ticket:
Release note: