Skip to content

Remove hanging brackets that cause error, simplify checkSquare function#5

Open
AustinMallar wants to merge 2 commits intokubowania:masterfrom
AustinMallar:master
Open

Remove hanging brackets that cause error, simplify checkSquare function#5
AustinMallar wants to merge 2 commits intokubowania:masterfrom
AustinMallar:master

Conversation

@AustinMallar
Copy link
Copy Markdown

  • Hanging brackets on the last line of app.js causes an error, simply removed to correct.
  • Simplify the checkSquare function by removing the "square" parameter as it isn't used in the function.

@thulin82
Copy link
Copy Markdown

  • Hanging bracket-fix already existing in Fixed hanging }). #3
  • Also, your commits do A LOT more than you are stating, and could be summarized by:
    • Changing ' to "
    • Adding semicolons
    • Expanding IF-syntaxes at line 46-55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants