Migrate Onset application ID to kulmin - #17
Merged
Merged
Conversation
BREAKING CHANGE: application ID, desktop file, and icon change from com.github.xPathin.onset to com.github.kulmin.onset. Desktop environments may require users to repin Onset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.github.xPathin.onsettocom.github.kulmin.onset.1.0.3to2.0.0; reset both PKGBUILD release numbers to1.Breaking change
Desktop environments may treat Onset 2 as a new application, so users may need to repin it. Package-manager upgrades should remove old package-owned launcher and icon files. Manual installations should remove the old launcher and icon after installing v2 to avoid duplicate menu entries.
Validation
cargo fmt --checkcargo clippy --locked -- -D warningscargo test --locked(21 passed)cargo build --release --lockedcargo metadata --locked --no-deps --format-version 1bash -nfor both PKGBUILDsmakepkg --printsrcinfofor both packagesdesktop-file-validate data/com.github.kulmin.onset.desktopxmllint --noout data/icons/hicolor/scalable/apps/com.github.kulmin.onset.svggit diff --checkdesktop-file-validateretains the existing non-failing hint that multiple main categories may duplicate the launcher in some menus.