Added mockgoose - #347
Open
Christilut wants to merge 5 commits into
Open
Conversation
|
This looks wrong. Mockgoose says it spins up a mongod and the example shows how to add this to the chai tests. Why do you implement it in the server? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mockgoose uses an in-memory version of mongodb so tests start fresh each time and no database is polluted should certain tests fail.
Edit: one thing ive noticed with Mockgoose is that if your internet is slow (or not available), the first test that uses mockgoose will fail with
timeout exceeded. I think this is because mockgoose is checking if the prebuilt mongodb binary is up to date. Not sure this is acceptable for this project but personally I'm okay with it. See Mockgoose/Mockgoose#20