Skip to content

V5.3.0 aarch64#10

Open
GitSoftwareNow wants to merge 6 commits intokunpengcompute:aarch64from
GitSoftwareNow:v5.3.0-aarch64
Open

V5.3.0 aarch64#10
GitSoftwareNow wants to merge 6 commits intokunpengcompute:aarch64from
GitSoftwareNow:v5.3.0-aarch64

Conversation

@GitSoftwareNow
Copy link
Copy Markdown

No description provided.

@minqian
Copy link
Copy Markdown
Collaborator

minqian commented Sep 25, 2020

Thank you for your support of arm ecology, we will review your code and make sure there is no problem to merge it.

#elif defined(HAVE_NEON)
__asm__ __volatile__("ldr w0, %w2 \n\t"
"bic %w0,w0,%w1 \n\t"
: "=r"(r)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our optimization, it is not recommended to modify.


u32 reach0, reach1, reach2, reach3;
u64a ptr = unaligned_load_u64a(itPtr);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also our optimization, it is not recommended to modify.

#define CRC32CB(crc, value) __asm__("crc32cb %w[c], %w[c], %w[v]":[c]"+r"(crc):[v]"r"(value))
#define CRC_WORD 8
#define CRC_TYPE u64a
static really_inline
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not recommended to modify for all of the “HAVE_NEON” branches.

}
#else
if (check_neon()) {
return HS_SUCCESS;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is needed for arm platform.

union RepeatControl *repeat_ctrl = ctx->repeat_ctrl + info->ctrlIndex;
char *repeat_state = ctx->repeat_state + info->stateOffset;

if (unlikely(e->trigger == LIMEX_TRIGGER_POS)) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These branch predictions can improve the performance and are not recommended to be deleted.

kylin added 4 commits November 2, 2020 12:54
Signed-off-by: kylin <karin.repos@icloud.com>
Signed-off-by: kylin <karin.repos@icloud.com>
Signed-off-by: kylin <karin.repos@icloud.com>
Signed-off-by: kylin <karin.repos@icloud.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 26, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


kylin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants