Skip to content

Add CSS font-size property (by kettlebell)#11

Open
epost wants to merge 2 commits intokwohlfahrt:masterfrom
statebox:kettlebell-css-font-size
Open

Add CSS font-size property (by kettlebell)#11
epost wants to merge 2 commits intokwohlfahrt:masterfrom
statebox:kettlebell-css-font-size

Conversation

@epost
Copy link
Copy Markdown

@epost epost commented May 15, 2019

This enhancement was made by kettlebell: kettlebell@d6d96ca.

@epost
Copy link
Copy Markdown
Author

epost commented May 15, 2019

FYI @kettlebell, I made a PR out of your contribution.

@kettlebell
Copy link
Copy Markdown

Hi @epost, thanks for arranging the pull request. I've recently returned to my repo and updated it to use Spago and Halogen 5 (wasn't too bad as you can see here)

Also it'd be great to flesh out some more of the SVG properties.

@epost
Copy link
Copy Markdown
Author

epost commented May 16, 2019

@kettlebell That's good to hear! I'm doing this in the hopes of converging on a repo that can be maintained, because we're using this at Statebox and I've added a fair number of features, including animation support. Here is a WIP document describing the current state of affairs: https://hackmd.io/lYvFcjb7STe2YzIet9sM7w?both. I've added the changes you just mentioned to the document.

@kwohlfahrt Would you consider making some of us contributors, so we can collaborate on maintenance tasks?

@rskew
Copy link
Copy Markdown

rskew commented Aug 23, 2019

@epost I've started using this repo and I've added a couple of small things here #14 (it looks like I've duplicated the marker functionality, woops).

If you have another repo for merging various changes I'll happily create a PR there :)

@epost
Copy link
Copy Markdown
Author

epost commented Aug 23, 2019

Hey @rskew, that is cool stuff! :D And a coincidence too; Sjoerd Visscher just started working on this yesterday at https://github.com/statebox/purescript-halogen-svg. Would be great if you could make a PR.

@rskew
Copy link
Copy Markdown

rskew commented Aug 24, 2019

Cheers @epost. I'll aim to make a PR soon, I'll have to update my parent project from Halogen 4 to 5 first.

@kwohlfahrt
Copy link
Copy Markdown
Owner

@epost @rskew - sorry for the long silence. As you guys can see, I'm no longer doing any purescript development so I don't have any personal use for this library. Would you prefer to be collaborators here, or alternatively I can replace it with a placeholder redirecting to another repo.

@rskew
Copy link
Copy Markdown

rskew commented Nov 11, 2019

@kwohlfahrt all good :) I'm up for whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants