fix(hook): persist open turns across Stop firings#19
Draft
milanagm wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes LFE-10747. Addresses point 1b of #5.
Stopfires multiple times within one logical turn and at the same time turn assembly was stateless per hook run. Meaning that the trailing turn was emitted at every Stop, and continuation rows arriving in the next batch (task notifications followed by assistant messages) were silently dropped.This PR:
open_turn_rows) and re-attachesit to the next batch; emitted once a new user row closes it or SessionEnd
flushes it
replays them once at session end
Known limits (unchanged from before): a hard-killed session that never resumes
loses its last open turn until
SessionEndreliability is improved (#13), andlate notifications for non-deferrable background tools (e.g. background Bash)
cannot attach once their turn is emitted.
Testing
stop_hook_summaryboundaries vs. single-pass ground truth: 11 previously truncated turns are
now complete, no duplicates