Skip to content

Comments

fix: change the method of update_dataset api in document#18197

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
chen622:main
Apr 17, 2025
Merged

fix: change the method of update_dataset api in document#18197
crazywoola merged 1 commit intolanggenius:mainfrom
chen622:main

Conversation

@chen622
Copy link
Contributor

@chen622 chen622 commented Apr 16, 2025

Summary

The API documentation of the knowledge base provides an incorrect HTTP request method for the update_dataset interface. The documentation shows POST, but PATCH is used in the code. Additionally, the documentation incorrectly describes the type of the retrieval_model parameter for the update_dataset interface; it should be of Object type.

image

Screenshots

Doc Code
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation labels Apr 16, 2025
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upgrade the template.ja.mdx as well :)

@chen622
Copy link
Contributor Author

chen622 commented Apr 17, 2025

Please upgrade the template.ja.mdx as well :)

The Japanese version seems to have been forgotten in the last update, so it does not provide an introduction related to update_dataset API. Please refer to PR #12237

@crazywoola
Copy link
Member

crazywoola commented Apr 17, 2025

Please upgrade the template.ja.mdx as well :)

The Japanese version seems to have been forgotten in the last update, so it does not provide an introduction related to update_dataset API. Please refer to PR #12237

I see, will find some time to add those back.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2025
@crazywoola crazywoola merged commit a1d2008 into langgenius:main Apr 17, 2025
5 checks passed
jsincorporated pushed a commit to jsincorporated/asaAi that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants