fix: change the method of update_dataset api in document#18197
Merged
crazywoola merged 1 commit intolanggenius:mainfrom Apr 17, 2025
Merged
fix: change the method of update_dataset api in document#18197crazywoola merged 1 commit intolanggenius:mainfrom
crazywoola merged 1 commit intolanggenius:mainfrom
Conversation
crazywoola
requested changes
Apr 16, 2025
Member
crazywoola
left a comment
There was a problem hiding this comment.
Please upgrade the template.ja.mdx as well :)
Contributor
Author
The Japanese version seems to have been forgotten in the last update, so it does not provide an introduction related to |
Member
I see, will find some time to add those back. |
crazywoola
approved these changes
Apr 17, 2025
jsincorporated
pushed a commit
to jsincorporated/asaAi
that referenced
this pull request
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The API documentation of the knowledge base provides an incorrect HTTP request method for the
update_datasetinterface. The documentation showsPOST, butPATCHis used in the code. Additionally, the documentation incorrectly describes the type of theretrieval_modelparameter for theupdate_datasetinterface; it should be ofObjecttype.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods