[13.x] Fix deprecation warning in In and NotIn rules when values contain null#59576
Merged
taylorotwell merged 1 commit intolaravel:13.xfrom Apr 7, 2026
Merged
Conversation
…ain null Same fix as laravel#59561 (Contains/DoesntContain) — str_replace() receives null from enum_value(null), generating a deprecation warning. The In and NotIn rules have the identical pattern that was missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #59561 fixed the null deprecation warning in
ContainsandDoesntContainrules. TheInandNotInrules have the identical pattern that was missed.Before
After
All four rules now consistent
ContainsDoesntContainInNotInChanges
src/Illuminate/Validation/Rules/In.php— Cast value to stringsrc/Illuminate/Validation/Rules/NotIn.php— Cast value to string