Prevent null values from reaching quote() and causing a TypeError#169
Open
PenguinNexus wants to merge 1 commit intolaravel:nextfrom
Open
Prevent null values from reaching quote() and causing a TypeError#169PenguinNexus wants to merge 1 commit intolaravel:nextfrom
PenguinNexus wants to merge 1 commit intolaravel:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens TypeScript generation by filtering out null and empty string values before invoking quote() on literal-union members. This prevents the following TypeError:
This is achieved by converting the arrays in
TypeScript::literalUnion()to a Collection then apply the filter to strip if is_null or an empty string. The same filter is then applied inValidation\Rules::resolveBaseType().There is an associated PR for Surveyor: laravel/surveyor#20