docs: migrate SPPF page from Bootstrap 4 to Bootstrap 5#1588
Open
akerem16 wants to merge 1 commit intolark-parser:masterfrom
Open
docs: migrate SPPF page from Bootstrap 4 to Bootstrap 5#1588akerem16 wants to merge 1 commit intolark-parser:masterfrom
akerem16 wants to merge 1 commit intolark-parser:masterfrom
Conversation
Fixes lark-parser#1494. Bootstrap 4 reached end-of-life on 2023-01-01. The SPPF article under docs/_static/sppf/sppf.html was the only page pinning Bootstrap 4. Changes: - Switch the stylesheet to Bootstrap 5.3.3 via the jsDelivr CDN (stackpath.bootstrapcdn.com does not host Bootstrap 5) and add an SRI integrity hash. - Rename the only deprecated utility class used on the page, pull-right, to its Bootstrap 5 equivalent float-end. No other Bootstrap utilities or components are referenced on this page, so no further migration steps are required. The page was rendered locally and the back-to-top anchor stays right-aligned as before.
akerem16
force-pushed
the
docs/bootstrap-5-migration
branch
from
7f3a00b to
b377e78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1494.
Migrates `docs/_static/sppf/sppf.html` off of Bootstrap 4 (EOL since 2023-01-01) onto Bootstrap 5.
Changes
Nothing else on the page uses Bootstrap classes, `data-toggle` attributes, or jQuery, so no further changes were needed.
Test plan