Skip to content

fix: stake add operation mapping for multi-hotkey and multi-netuid #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bitloi wants to merge 1 commit into
base: staging
Choose a base branch
from
+257 −121
Open

fix: stake add operation mapping for multi-hotkey and multi-netuid #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
236 changes: 117 additions & 119 deletions bittensor_cli/src/commands/stake/add.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,119 +339,134 @@ async def stake_extrinsic(
)

# Determine the amount we are staking.
rows = []
amounts_to_stake = []
current_stake_balances = []
prices_with_tolerance = []
remaining_wallet_balance = current_wallet_balance
max_slippage = 0.0

operation_targets = []
for hotkey in hotkeys_to_stake_to:
for netuid in netuids:
# Check that the subnet exists.
subnet_info = all_subnets.get(netuid)
if not subnet_info:
print_error(f"Subnet with netuid: {netuid} does not exist.")
continue
current_stake_balances.append(hotkey_stake_map[hotkey[1]][netuid])

# Get the amount.
amount_to_stake = Balance(0)
if amount:
amount_to_stake = Balance.from_tao(amount)
elif stake_all:
amount_to_stake = current_wallet_balance / len(netuids)
elif not amount:
amount_to_stake, _ = _prompt_stake_amount(
current_balance=remaining_wallet_balance,
netuid=netuid,
action_name="stake",
)
amounts_to_stake.append(amount_to_stake)
operation_targets.append(
(hotkey, netuid, subnet_info, hotkey_stake_map[hotkey[1]][netuid])
)

# Check enough to stake.
if amount_to_stake > remaining_wallet_balance:
print_error(
f"Not enough stake:[bold white]\n wallet balance:{remaining_wallet_balance} < "
f"staking amount: {amount_to_stake}[/bold white]"
)
return
remaining_wallet_balance -= amount_to_stake

# Calculate slippage
# TODO: Update for V3, slippage calculation is significantly different in v3
# try:
# received_amount, slippage_pct, slippage_pct_float, rate = (
# _calculate_slippage(subnet_info, amount_to_stake, stake_fee)
# )
# except ValueError:
# return False
#
# max_slippage = max(slippage_pct_float, max_slippage)

# Temporary workaround - calculations without slippage
current_price_float = float(subnet_info.price.tao)
rate = _safe_inverse_rate(current_price_float)

# If we are staking safe, add price tolerance
if safe_staking:
if subnet_info.is_dynamic:
price_with_tolerance = current_price_float * (1 + rate_tolerance)
_rate_with_tolerance = _safe_inverse_rate(
price_with_tolerance
) # Rate only for display
rate_with_tolerance = f"{_rate_with_tolerance:.4f}"
price_with_tolerance = Balance.from_tao(
price_with_tolerance
) # Actual price to pass to extrinsic
else:
rate_with_tolerance = "1"
price_with_tolerance = Balance.from_rao(1)
extrinsic_fee = await get_stake_extrinsic_fee(
netuid_=netuid,
amount_=amount_to_stake,
staking_address_=hotkey[1],
safe_staking_=safe_staking,
price_limit=price_with_tolerance,
)
prices_with_tolerance.append(price_with_tolerance)
row_extension = [
f"{rate_with_tolerance} {Balance.get_unit(netuid)}/{Balance.get_unit(0)} ",
f"[{'dark_sea_green3' if allow_partial_stake else 'red'}]"
# safe staking
f"{allow_partial_stake}[/{'dark_sea_green3' if allow_partial_stake else 'red'}]",
]
if stake_all and not operation_targets:
print_error("No valid staking operations to perform.")
return

rows = []
operations = []
remaining_wallet_balance = current_wallet_balance
max_slippage = 0.0

for hotkey, netuid, subnet_info, current_stake_balance in operation_targets:
staking_address = hotkey[1]

# Get the amount.
amount_to_stake = Balance(0)
if amount:
amount_to_stake = Balance.from_tao(amount)
elif stake_all:
amount_to_stake = current_wallet_balance / len(operation_targets)
elif not amount:
amount_to_stake, _ = _prompt_stake_amount(
current_balance=remaining_wallet_balance,
netuid=netuid,
action_name="stake",
)

# Check enough to stake.
if amount_to_stake > remaining_wallet_balance:
print_error(
f"Not enough stake:[bold white]\n wallet balance:{remaining_wallet_balance} < "
f"staking amount: {amount_to_stake}[/bold white]"
)
return
remaining_wallet_balance -= amount_to_stake

# Calculate slippage
# TODO: Update for V3, slippage calculation is significantly different in v3
# try:
# received_amount, slippage_pct, slippage_pct_float, rate = (
# _calculate_slippage(subnet_info, amount_to_stake, stake_fee)
# )
# except ValueError:
# return False
#
# max_slippage = max(slippage_pct_float, max_slippage)

# Temporary workaround - calculations without slippage
current_price_float = float(subnet_info.price.tao)
rate = _safe_inverse_rate(current_price_float)
price_with_tolerance = None

# If we are staking safe, add price tolerance
if safe_staking:
if subnet_info.is_dynamic:
price_with_tolerance = current_price_float * (1 + rate_tolerance)
_rate_with_tolerance = _safe_inverse_rate(
price_with_tolerance
) # Rate only for display
rate_with_tolerance = f"{_rate_with_tolerance:.4f}"
price_with_tolerance = Balance.from_tao(
price_with_tolerance
) # Actual price to pass to extrinsic
else:
extrinsic_fee = await get_stake_extrinsic_fee(
netuid_=netuid,
amount_=amount_to_stake,
staking_address_=hotkey[1],
safe_staking_=safe_staking,
)
row_extension = []
# TODO this should be asyncio gathered before the for loop
amount_minus_fee = (
(amount_to_stake - extrinsic_fee) if not proxy else amount_to_stake
rate_with_tolerance = "1"
price_with_tolerance = Balance.from_rao(1)
extrinsic_fee = await get_stake_extrinsic_fee(
netuid_=netuid,
amount_=amount_to_stake,
staking_address_=staking_address,
safe_staking_=safe_staking,
price_limit=price_with_tolerance,
)
row_extension = [
f"{rate_with_tolerance} {Balance.get_unit(netuid)}/{Balance.get_unit(0)} ",
f"[{'dark_sea_green3' if allow_partial_stake else 'red'}]"
# safe staking
f"{allow_partial_stake}[/{'dark_sea_green3' if allow_partial_stake else 'red'}]",
]
else:
extrinsic_fee = await get_stake_extrinsic_fee(
netuid_=netuid,
amount_=amount_to_stake,
staking_address_=staking_address,
safe_staking_=safe_staking,
)
sim_swap = await subtensor.sim_swap(
origin_netuid=0,
destination_netuid=netuid,
amount=amount_minus_fee.rao,
row_extension = []
# TODO this should be asyncio gathered before the for loop
amount_minus_fee = (
(amount_to_stake - extrinsic_fee) if not proxy else amount_to_stake
)
sim_swap = await subtensor.sim_swap(
origin_netuid=0,
destination_netuid=netuid,
amount=amount_minus_fee.rao,
)
received_amount = sim_swap.alpha_amount
# Add rows for the table
base_row = [
str(netuid), # netuid
f"{staking_address}", # hotkey
str(amount_to_stake), # amount
str(rate) + f" {Balance.get_unit(netuid)}/{Balance.get_unit(0)} ", # rate
str(received_amount.set_unit(netuid)), # received
str(sim_swap.tao_fee), # fee
str(extrinsic_fee),
# str(slippage_pct), # slippage
] + row_extension
rows.append(tuple(base_row))
operations.append(
(
netuid,
staking_address,
amount_to_stake,
current_stake_balance,
price_with_tolerance,
)
received_amount = sim_swap.alpha_amount
# Add rows for the table
base_row = [
str(netuid), # netuid
f"{hotkey[1]}", # hotkey
str(amount_to_stake), # amount
str(rate)
+ f" {Balance.get_unit(netuid)}/{Balance.get_unit(0)} ", # rate
str(received_amount.set_unit(netuid)), # received
str(sim_swap.tao_fee), # fee
str(extrinsic_fee),
# str(slippage_pct), # slippage
] + row_extension
rows.append(tuple(base_row))
)

# Define and print stake table + slippage warning
table = _define_stake_table(wallet, subtensor, safe_staking, rate_tolerance)
Expand All @@ -467,23 +482,6 @@ async def stake_extrinsic(
if not unlock_key(wallet).success:
return

# Build the list of (netuid, hotkey, amount, current_stake, price_limit) tuples
# that describe each staking operation we need to perform.
# The zip aligns netuids with amounts/balances (which are populated per
# hotkey-netuid pair, but the zip truncates to len(netuids), matching the
# original execution order). Each netuid's amount/price applies to all hotkeys.
operations = []
if safe_staking:
for ni, am, curr, price in zip(
netuids, amounts_to_stake, current_stake_balances, prices_with_tolerance
):
for _, staking_address in hotkeys_to_stake_to:
operations.append((ni, staking_address, am, curr, price))
else:
for ni, am, curr in zip(netuids, amounts_to_stake, current_stake_balances):
for _, staking_address in hotkeys_to_stake_to:
operations.append((ni, staking_address, am, curr, None))

total_ops = len(operations)
use_batch = total_ops > 1

Expand Down
Loading
Loading