Skip to content

Comments

Mistcloak v2#159

Open
SoaringEaqle wants to merge 19 commits intoleafreynolds:developfrom
SoaringEaqle:mistcloak_V2
Open

Mistcloak v2#159
SoaringEaqle wants to merge 19 commits intoleafreynolds:developfrom
SoaringEaqle:mistcloak_V2

Conversation

@SoaringEaqle
Copy link
Contributor

Changes proposed in this pull request:

Fixes mistcloak render by making it a Curios item to go in the head slot.
Overhauls Shardplate

  1. Shardplate is now one Curios item instead of four armor pieces.
  2. 10 new Shardplate items, one for each order minus Bondsmiths plus deadplate
  3. Dynamic models for shardplate
  4. Shardplate is a chargable item that can be restored by
  • crafting with broams with stormlight
  • siphoning from surgebinders
  1. Shardplate adds buffs when charged and problems when empty.
  2. shardplate buffs are handled in ShardplateCurioItem class instead of SurgebindingSpiritwebSubmodule

SoaringEaqle and others added 4 commits July 13, 2025 23:38
Shardplate buffs now handled by shardplate item.
Shardplate now has a charge. this can be refilled by placing broams and the shardplate in a crafting grid, or it can siphon off a player's stormlight.

Signed-off-by: SoaringEaqle <158627775+SoaringEaqle@users.noreply.github.com>
@SoaringEaqle
Copy link
Contributor Author

SoaringEaqle commented Jul 24, 2025

There's some stuff that still needs done, but it's mostly to do with how radiant shardplate works and interacts with radiants, so it's probably best to add it after radiants get added. Instead of working around a system that barely exists yet.

Data for Shardplate and Blades -- including order, state of living or deadeye, who their bonded to, and how long they've been trying to bond to a player -- are now controlled by capabilities.

Suits of shardplate for each order have been removed.

The color of shardplate is now determined by the capability and its data.
@SoaringEaqle
Copy link
Contributor Author

Needed a break from Investiture System, so mostly redid this. Hopefully this redesign makes it easier to influence data, and manipulate deadeye states, as well as control bonding easier.

Bug fixes for shard blades and plate
Color changes for blade and plate
new mistcloak texture.
Mistcloak now functions as a weak armor, and reduces player gravity allowing for better steeljumping.
Signed-off-by: SoaringEaqle <158627775+SoaringEaqle@users.noreply.github.com>
Signed-off-by: SoaringEaqle <158627775+SoaringEaqle@users.noreply.github.com>
@Gerbagel
Copy link
Collaborator

Don't see any issues with the Mistcloak.

However, when I go to change out one piece of Shardplate for another, the second one becomes the same type as the first. This happens regardless of Dead or living plate.

SurgebindingItemModelsGen.java is also missing a couple imports for GemstoneItem and ShardplateCurioItem.

I also get java.lang.IllegalArgumentException: Texture surgebinding:item/gemstone_chip does not exist in any known resource pack when I try to runData, which I was doing to see if the lack of a Curios slot name for Shardplate was just because I hadn't generated.

@SoaringEaqle
Copy link
Contributor Author

I did notice that, however, I do not know how to fix it. My assumption is that it is a quirk with curios. I think the best way to bypass it would be to store the data somewhere when you try to equip, and come back a few ticks later and reattach the data, but I really have no clue what that would look like.

@leafreynolds
Copy link
Owner

In future, we also don't want multiple features packed into a single pull request. This one is called mistcloak, but is mostly full of surgebinding stuff.

@SoaringEaqle
Copy link
Contributor Author

Sorry about that. I just needed a bunch of stuff I made for the mistcloak for the Shardplate, and I didn't want to go through the effort of duplicating the branch and removing the mistcloak-specific code.

This reverts commit e4b93c6.
@SoaringEaqle
Copy link
Contributor Author

SurgebindingItemModelsGen.java is also missing a couple imports for GemstoneItem and ShardplateCurioItem.

I also get java.lang.IllegalArgumentException: Texture surgebinding:item/gemstone_chip does not exist in any known resource pack when I try to runData, which I was doing to see if the lack of a Curios slot name for Shardplate was just because I hadn't generated.

These two issues should be resolved. It was some issue where the files half updated, but not completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants