Skip to content

fix: deprecate IsTotal in favour of Std.Total - #30855

Closed
Ruben-VandeVelde wants to merge 1 commit into
masterfrom
Std.Total
Closed

fix: deprecate IsTotal in favour of Std.Total#30855
Ruben-VandeVelde wants to merge 1 commit into
masterfrom
Std.Total

Conversation

@Ruben-VandeVelde

Copy link
Copy Markdown
Contributor

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the RFC Request for comment label Oct 24, 2025
@github-actions

Copy link
Copy Markdown

PR summary ba4e2b0243

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ LinearOrder.inst_stdTotal_le
+ LowerSet.inst_stdTotal_le
+ OrderDual.inst_stdTotal_le
+ Prop.inst_stdTotal_le
+ Std.Total.compRel
+ Std.Total.decide
+ Std.Total.directed
+ Std.Total.inst_ge_of_le
+ Std.Total.isTrichotomous
+ Std.Total.not_incompRel
+ Std.Total.swap
+ UpperSet.inst_stdTotal_le
+ inst_stdTotal
+ inst_stdTotal_left
+ inst_stdTotal_right
+ instance (priority := 100) Std.Total.to_isDirected [Std.Total r] : IsDirected α r
+ instance (priority := 100) Std.Total.to_isRefl (r) [Std.Total r] : IsRefl α r
+ instance : Std.Total (α := MulArchimedeanOrder M) (· ≤ ·)
+ instance [DecidableLE α] [DecidableLT α] [Std.Total (α := α) (· ≤ ·)] :
+ instance [IsTrichotomous ι r] [∀ i, Std.Total (s i)] : Std.Total (Lex r s)
+ instance [LinearOrder α] : Std.Total (α := α) (· ≥ ·)
+ instance [Std.Total r] [Std.Total s] : Std.Total (Lex r s)
+ instance {α : Sort*} (r) [Std.Total r] : IsTotal α r
+ instance {α} [Encodable α] : Std.Total (Encodable.encode' α ⁻¹'o (· ≤ ·))
+ multiplicative_of_stdTotal
+ multiplicative_of_symmetric_of_stdTotal
+ stdTotal
++++++++ inst_stdTotal_le
- LowerSet.isTotal_le
- Prop.le_isTotal
- UpperSet.isTotal_le
- instance : IsTotal (MulArchimedeanOrder M) (· ≤ ·)
- instance [DecidableLE α] [DecidableLT α] [IsTotal α (· ≤ ·)] :
- instance [IsTotal α r] [IsTotal β s] : IsTotal (α ⊕ β) (Lex r s)
- instance [IsTrichotomous ι r] [∀ i, IsTotal (α i) (s i)] : IsTotal _ (Lex r s)
- instance [LinearOrder α] : IsTotal α (· ≥ ·)
- instance {α} [Encodable α] : IsTotal _ (Encodable.encode' α ⁻¹'o (· ≤ ·))
- isTotal_left
- isTotal_right
- leTotal_R
-- isTotal
-- le_total_ideal
--- isTotal_le

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 18, 2025
@mathlib4-merge-conflict-bot

Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@wrenna-robson

Copy link
Copy Markdown
Collaborator

Where is this at?

@alexjbest alexjbest removed their assignment Jan 3, 2026
@SnirBroshi SnirBroshi added the t-order Order theory label Jan 8, 2026
@Ruben-VandeVelde

Copy link
Copy Markdown
Contributor Author

#33797

@Ruben-VandeVelde
Ruben-VandeVelde deleted the Std.Total branch January 28, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) RFC Request for comment t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants