Rebuilt Documentation in Gitbook #37
Open
AlinaWithAFace wants to merge 212 commits intoleapmotion:masterfrom
Open
Rebuilt Documentation in Gitbook #37AlinaWithAFace wants to merge 212 commits intoleapmotion:masterfrom
AlinaWithAFace wants to merge 212 commits intoleapmotion:masterfrom
Conversation
jselstad
suggested changes
Aug 23, 2019
Contributor
jselstad
left a comment
jselstad
left a comment
There was a problem hiding this comment.
Wow, this looks great! Gitbook is a huge visual upgrade over the standard Github readmes.
A couple questions:
- Is this missing a
book.json? - How is ownership of the pages managed with respect to gitbook.io? My current impression is that we'll need to initialize a separate Gitbook.io instance from your staging deployment.
Once the pieces below and the merge conflicts are fixed (and @fmaurer approves), I see no reason not to merge this.
Contributor
Author
|
I've only been working with gitbook for the past month or so using their webapp client, so admittedly I don't know if it's missing a |
# Conflicts: # Mechanical/CHANGELOG.md # Mechanical/README.md # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can see the results here, but basically I rebuilt all of the documentation to work with gitbook since it's a bit more user-friendly compared to READMEs scattered throughout folders.