Updates to Calibration Readme and small fix to dualStereoChessboardCalibration.py#38
Open
BryanChrisBrown wants to merge 1 commit intoleapmotion:masterfrom
BryanChrisBrown:CalibrationFixes
Open
Updates to Calibration Readme and small fix to dualStereoChessboardCalibration.py#38BryanChrisBrown wants to merge 1 commit intoleapmotion:masterfrom BryanChrisBrown:CalibrationFixes
BryanChrisBrown wants to merge 1 commit intoleapmotion:masterfrom
BryanChrisBrown:CalibrationFixes
Conversation
Specifically regarding the importation of opencv, the readme currently states to import opencv-python, however this does not include the proper files in order to import aruco, which exists in the extended library opencv-contrib-python. I've also added an additional flag ", allow_pickle=True"to the .npz file import in the dualStereoChessboardCalibration.py file, located on line 77. We wasted a lot of time trying to figure out why numpy couldn't parse the .npz file in our python environments and this solved that issue. Special thanks to Alina Christenbury and SafariMonkey from the northstar discord server for working with me on this.
jselstad
suggested changes
Oct 23, 2019
Contributor
There was a problem hiding this comment.
Ah, so the aruco library and opencv-python-contrib aren't actually used in the calibrator; I must have accidentally left the include behind after some experimentation with the ChArUco calibration system. Apologies about that, my bad.
The , allow_pickle=True) flag is a good catch; it seems like somewhat recent versions of NumPy require it.
If you remove the import cv2.aruco as aruco line from the top of the python file and change the readme back, I'll merge it asap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readme for the calibration software currently states to import
opencv-python, however this does not include the proper files in order to importaruco, which exists in the extended libraryopencv-contrib-python.I've also added an additional flag
, allow_pickle=True)to the .npz file import in the dualStereoChessboardCalibration.py file, located on line 77. We wasted a lot of time trying to figure out why numpy couldn't parse the .npz file in our python environments and this solved that issue.Special thanks to Alina Christenbury and SafariMonkey from the northstar discord server for working with me on this.