["floating" feature branch] Add useKFloatingPosition#1240
Merged
MisRob merged 4 commits intoApr 23, 2026
Conversation
MisRob
force-pushed
the
floating-production-01
branch
from
April 21, 2026 18:48
ec3d54e to
20a704e
Compare
MisRob
marked this pull request as ready for review
April 21, 2026 18:48
rtibblesbot
reviewed
Apr 21, 2026
rtibblesbot
left a comment
Contributor
There was a problem hiding this comment.
Clean, focused addition of useKFloatingPosition with solid documentation.
CI passing. Verified the three new/updated docs pages (useKFloatingPosition, floatingelements, browsersupport) and the interactive tooltip example against the Netlify preview — all render correctly, the DocsWarning component is visually consistent, and the tooltip example works as expected. No design spec to compare against; color-contrast and html-lang a11y violations are pre-existing site-wide issues.
- suggestion: missing
.catch()on thecomputePositionpromise — see inline - suggestion: test mock resolves with
{}but no assertion covers the style update — see inline - nitpick: partial mock leaves middleware exports undefined — see inline
- praise: defensive cleanup before re-init, verified by tests — see inline
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Reviewed the pull request diff checking for:
- Correctness: bugs, edge cases, undocumented behavior, resource leaks, hardcoded values
- Design: unnecessary complexity, naming, readability, comment accuracy, redundant state
- Architecture: duplicated concerns, minimal interfaces, composition over inheritance
- Testing: behavior-based assertions, mocks only at hard boundaries, accurate coverage
- Completeness: missing dependencies, unupdated usages, i18n, accessibility, security
- Principles: DRY (same reason to change), SRP, Rule of Three (no premature abstraction)
- Checked CI status and linked issue acceptance criteria
- For UI changes: inspected screenshots for layout, visual completeness, and consistency
rtibbles
approved these changes
Apr 22, 2026
rtibbles
left a comment
Member
There was a problem hiding this comment.
All changes make sense to me.
MisRob
merged commit Apr 23, 2026
1384266
into
learningequality:floating-production
6 of 10 checks passed
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The first PR in the series that aims to prepare selected parts of #1114 for production environment. Targets
floating-productionfeature branch. The next PR will be foruseKFloatingInteraction.Adds
useKFloatingPositioncomposable with new documentation pagesNote that Floating UI may be replaced by Popper, depending on results of browser testing in Kolibri & dev discussion (the structure of the composable and documentation will be the same for both, except few differences).
Issue addressed
Part of #1158
Changelog
Skipped. Will prepare the changelog before merging the feature branch to
develop.AI usage
I used Claude for draft and then further assistance when iterating on it. There's not a place that I wouldn't tweak or see ;) Also self-reviewed the final diff fully.