KCheckbox: Use flex rather than table for display#968
Draft
nucleogenesis wants to merge 1 commit into
Draft
Conversation
Using the table display value resulted in the checkbox icon having some unnecessary space beneath it which can make centering it bothersome when not using the label prop.
Member
|
Overall, this seems good. My only concern is that the checkbox container overall seems slightly narrower in height. If we match the height with some padding to compensate, I presume that will produce less regressions, but open to thoughts. |
Contributor
Percy Visual Test ResultsPercy Dashboard: View Detailed Report Environment:
Instructions for Reviewers:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before:
See how when the box is highlighted, there is space under it.
Screencast_20250318_161152.webm
After
See how now the checkbox and its label are equal height & centered together
Screencast_20250318_161241.webm
Issue addressed
Using the table display value resulted in the checkbox icon having some unnecessary space beneath it which can make centering it bothersome when not using the label prop.
For example - here in Kolibri we have some /deep/ styling to mitigate this by moving the box itself down a bit like so:
Changelog