Add new 2025 Microsoft Teams icon - #876
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR updates the Microsoft Teams icon asset configuration by removing alternate variant entries and adding vector/rendering properties. It also adds a changelog entry noting the icon redesign. ChangesMS Teams icon update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Microsoft Teams icon to the new 2025 design, consolidating from separate light/dark mode icons to a single universal icon that works across all appearances.
- Replaced old MS Teams SVG icon with the new 2025 design
- Removed the duplicate light-mode specific icon file
- Updated asset catalog configuration to use a single icon for all appearances
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ms-teams-icon.svg | Updated to the new 2025 Microsoft Teams icon design with updated gradient colors and paths |
| ms-teams-icon-1.svg | Removed the duplicate light-mode specific icon file (no longer needed) |
| Contents.json | Simplified configuration to use single icon for all appearances, added vector preservation settings |
| CHANGELOG.md | Added changelog entry documenting the icon update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "preserves-vector-representation" : true, | ||
| "template-rendering-intent" : "original" |
There was a problem hiding this comment.
The closing brace on line 15 is missing from the diff. Ensure the JSON is properly closed with a brace after line 14.
| "preserves-vector-representation" : true, | |
| "template-rendering-intent" : "original" | |
| "preserves-vector-representation" : true, | |
| "template-rendering-intent" : "original" | |
| } |
|
Hey @vakesz! 👋 Just wanted to give this a friendly nudge — the PR looks great and @leits has already approved it. It seems like it just needs the merge conflict resolved to get the CI checks running and finally land this. Would you have a moment to rebase against master? Would love to see the new Teams icon make it in! 🎉 |
845d46b to
bd54407
Compare
Removed the 'Unreleased' section and its content from the changelog.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10287032 | Triggered | Generic Password | 77aad17 | MeetingBarLogicTests/MeetingLinkDetectorTests.swift | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Status
READY
Description
Replace old MS teams icons
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
Fixes: #871
Summary by CodeRabbit