Skip to content

Add new 2025 Microsoft Teams icon - #876

Merged
leits merged 5 commits into
leits:masterfrom
vakesz:feat-update-ms-teams-icon
Jul 3, 2026
Merged

Add new 2025 Microsoft Teams icon#876
leits merged 5 commits into
leits:masterfrom
vakesz:feat-update-ms-teams-icon

Conversation

@vakesz

@vakesz vakesz commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

Status

READY

Description

Replace old MS teams icons

Checklist

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

Fixes: #871

Summary by CodeRabbit

  • Style
    • Updated the MS Teams icon to the new design and standardized its vector rendering settings for consistent scaling and appearance.
  • Documentation
    • Added an Unreleased changelog note about the MS Teams icon update.

Copilot AI review requested due to automatic review settings November 12, 2025 15:08
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 12, 2025
@coderabbitai

coderabbitai Bot commented Nov 12, 2025

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 268d9207-a1e3-40a0-8220-6707bfd833d0

📥 Commits

Reviewing files that changed from the base of the PR and between 8c3318e and bd54407.

⛔ Files ignored due to path filters (2)
  • MeetingBar/Assets.xcassets/vendor-icons/ms_teams_icon.imageset/ms-teams-icon-1.svg is excluded by !**/*.svg
  • MeetingBar/Assets.xcassets/vendor-icons/ms_teams_icon.imageset/ms-teams-icon.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • CHANGELOG.md
  • MeetingBar/Assets.xcassets/vendor-icons/ms_teams_icon.imageset/Contents.json
✅ Files skipped from review due to trivial changes (1)
  • CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • MeetingBar/Assets.xcassets/vendor-icons/ms_teams_icon.imageset/Contents.json

Walkthrough

The PR updates the Microsoft Teams icon asset configuration by removing alternate variant entries and adding vector/rendering properties. It also adds a changelog entry noting the icon redesign.

Changes

MS Teams icon update

Layer / File(s) Summary
Asset definition and release note
MeetingBar/Assets.xcassets/vendor-icons/ms_teams_icon.imageset/Contents.json, CHANGELOG.md
The Teams icon asset keeps the primary SVG, drops the alternate light/dark variant entries, adds vector preservation and original rendering properties, and the changelog records the redesign.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hop on by with icon cheer,
A fresher Teams badge now appears.
One SVG, neat and bright,
With changelog notes to mark it right.
Hop hop hooray, the design is here!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The SVG asset files needed to verify the new icon and light/dark behavior were excluded by !**/*.svg, so compliance cannot be fully confirmed. Provide a reviewable diff for ms-teams-icon.svg and ms-teams-icon-1.svg, or remove the exclusion so the asset contents can be verified.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately states the main change: updating the Microsoft Teams icon.
Out of Scope Changes check ✅ Passed The changes stay on scope with the Teams icon update and a changelog note; no unrelated code paths were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Microsoft Teams icon to the new 2025 design, consolidating from separate light/dark mode icons to a single universal icon that works across all appearances.

  • Replaced old MS Teams SVG icon with the new 2025 design
  • Removed the duplicate light-mode specific icon file
  • Updated asset catalog configuration to use a single icon for all appearances

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
ms-teams-icon.svg Updated to the new 2025 Microsoft Teams icon design with updated gradient colors and paths
ms-teams-icon-1.svg Removed the duplicate light-mode specific icon file (no longer needed)
Contents.json Simplified configuration to use single icon for all appearances, added vector preservation settings
CHANGELOG.md Added changelog entry documenting the icon update

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
"preserves-vector-representation" : true,
"template-rendering-intent" : "original"

Copilot AI Nov 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing brace on line 15 is missing from the diff. Ensure the JSON is properly closed with a brace after line 14.

Suggested change
"preserves-vector-representation" : true,
"template-rendering-intent" : "original"
"preserves-vector-representation" : true,
"template-rendering-intent" : "original"
}

Copilot uses AI. Check for mistakes.
leits
leits previously approved these changes Mar 3, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 3, 2026
@pabloyeves

Copy link
Copy Markdown

Hey @vakesz! 👋 Just wanted to give this a friendly nudge — the PR looks great and @leits has already approved it. It seems like it just needs the merge conflict resolved to get the CI checks running and finally land this. Would you have a moment to rebase against master? Would love to see the new Teams icon make it in! 🎉

@vakesz
vakesz force-pushed the feat-update-ms-teams-icon branch from 845d46b to bd54407 Compare June 30, 2026 08:32
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 30, 2026
Removed the 'Unreleased' section and its content from the changelog.
@gitguardian

gitguardian Bot commented Jul 3, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10287032 Triggered Generic Password 77aad17 MeetingBarLogicTests/MeetingLinkDetectorTests.swift View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@leits
leits merged commit f3ae172 into leits:master Jul 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Change Microsoft Teams icon to new one

4 participants