Skip to content

Added minibatchNMF and added scikit-learn to packages#837

Merged
mdekstrand merged 6 commits into
lenskit:mainfrom
ywcharles:add-mini-batch-nmf
May 24, 2026
Merged

Added minibatchNMF and added scikit-learn to packages#837
mdekstrand merged 6 commits into
lenskit:mainfrom
ywcharles:add-mini-batch-nmf

Conversation

@ywcharles
Copy link
Copy Markdown
Contributor

  1. Added scikit-learn to the packages as uv sync did not installed it
  2. Added mini-batch NMF

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (b020964) to head (f419e65).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #837   +/-   ##
=======================================
  Coverage   89.67%   89.68%           
=======================================
  Files         247      247           
  Lines       16729    16737    +8     
=======================================
+ Hits        15002    15010    +8     
  Misses       1727     1727           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdekstrand
Copy link
Copy Markdown
Member

scikit-learn is an optional dependency — uv sync --extra=sklearn or uv sync --all-extras will include it in the install.

@mdekstrand mdekstrand linked an issue Oct 23, 2025 that may be closed by this pull request
3 tasks
@mdekstrand mdekstrand self-assigned this Oct 23, 2025
@mdekstrand mdekstrand added the components LensKit recommendation components label Oct 23, 2025
@mdekstrand mdekstrand merged commit f16c175 into lenskit:main May 24, 2026
41 checks passed
@mdekstrand mdekstrand added this to the 2026.2 milestone May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

components LensKit recommendation components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for MiniBatchNMF to NMF scorer

2 participants