feat: add vlan and qinq symbolic names for allow_ethertype#52
Open
leodido wants to merge 1 commit intofeat/allow-ethertypefrom
Open
feat: add vlan and qinq symbolic names for allow_ethertype#52leodido wants to merge 1 commit intofeat/allow-ethertypefrom
vlan and qinq symbolic names for allow_ethertype#52leodido wants to merge 1 commit intofeat/allow-ethertypefrom
Conversation
Add 'vlan' (0x8100) and 'qinq' (0x88A8) to the EtherType name lookup table. Users on VLAN-tagged networks can now write 'allow_ethertype ipv4+arp+vlan' instead of using raw hex values. Co-authored-by: Ona <no-reply@ona.com>
fntlnz
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
vlan(0x8100) andqinq(0x88A8) to the EtherType symbolic name table so users on VLAN-tagged networks can writeallow_ethertype ipv4+arp+vlaninstead of raw hex values.Changes
api/input_parse.h: addvlan→0x8100andqinq→0x88A8tog_ethertype_names[]test/cli.flags.bats: two tests verifying the names resolve to the correct hex values (via duplicate detection)README.txt,docs/README.md: updated symbolic name lists and VLAN documentation to reference the new namesStacked on
allow_ethertypeL2 gatekeeper #51 (feat/allow-ethertype)