Skip to content

Rename 'testnet' network to 'testnet3' #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecodefactory merged 1 commit into from
Jun 10, 2026
Merged

Rename 'testnet' network to 'testnet3' #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/bitcoin/network/settings.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ struct BCT_API settings
seeds.emplace_back("mainnet4.libbitcoin.net", 8333_u16);
break;
}
case system::chain::selection::testnet:
case system::chain::selection::testnet3:
{
seeds.reserve(4);
seeds.emplace_back("testnet1.libbitcoin.net", 18333_u16);
Expand Down Expand Up @@ -235,7 +235,7 @@ struct BCT_API settings
binds.emplace_back(asio::address{}, 8333_u16);
break;
}
case system::chain::selection::testnet:
case system::chain::selection::testnet3:
{
binds.emplace_back(asio::address{}, 18333_u16);
break;
Expand Down
6 changes: 3 additions & 3 deletions src/settings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,9 @@ static uint32_t identifier_from_context(chain::selection context) NOEXCEPT
{
switch (context)
{
case chain::selection::mainnet: return 3652501241;
case chain::selection::testnet: return 118034699;
case chain::selection::regtest: return 3669344250;
case chain::selection::mainnet: return 3652501241;
case chain::selection::testnet3: return 118034699;
case chain::selection::regtest: return 3669344250;
default: return 0;
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/settings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ BOOST_AUTO_TEST_CASE(settings__construct__mainnet__expected)

BOOST_AUTO_TEST_CASE(settings__construct__testnet__expected)
{
settings instance{ selection::testnet };
settings instance{ selection::testnet3 };
BOOST_REQUIRE_EQUAL(instance.identifier, 118034699u);
}

Expand Down
Loading