bad-number-2531-fix - #2669
Open
esdorman wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2531
This patch addresses an issue where input amounts with excessive decimal precision (e.g., '0.833') resulted in a generic, confusing "X is not a valid number" error.
Changes
TooManyDecimalPlacesException: Defined a specificTooManyDecimalPlacesexception inliberapay/exceptions.py.parse_money_amount: Modified the logic inliberapay/i18n/base.pyto raise this new, specific exception whenmoney.amount != decimal.This ensures that users receive a clear error message explaining the precision issue, aligning with the maintainer's request to "improve the error message" instead of allowing ambiguous number validation failures.