Hotfix/pirania

[usg-ishimura]

This pull request fixes some bugs found in Pirania captive portal, I tested the fixes building LibreMesh with BuildRoot over OpenWrt v23.05.5 and flashing the firmware to a GL-AR300M16-Ext device, also the tests from ./run_tests are all passing.

Here are the changes I made:

• Fixed portal front-end js errors which broke countdown and kept continue button disabled preventing from authenticating in the network.
• Solved a 502 bad gateway success redirect bug for voucher portal and read_for_access.
• Aligned read_for_access test to the bad gateway bug fix.
• Added a nftable rule that blocks HTTPS packets for unauthenticated MACs
• Restored /etc/init.d/pirania script functionality by decommenting one line in the captive-portal script.

The changes can be tested adding this repo in the feeds
src-git libremesh https://github.com/usg-ishimura/lime-packages.git;hotfix/pirania

[ilario]

The changes look great to me! But I did not test.
Can anyone check and test this?
@luandro @henmohr @germanferrero @spiccinini @gmarcos87
The maintainer of the package as indicated in the Makefile is Altermundi, so also pls @nicoechaniz tell us what you think.

I think it would be great to fix these things in Pirania while waiting for its rewrite that is happening in #1164

[luandro]

I've been travelling the whole month, without any equipment to properly test this. Why was it closed @usg-ishimura ?

[ilario]

I've been travelling the whole month, without any equipment to properly test this. Why was it closed @usg-ishimura ?

It has been closed in favour of #1224, as the latter includes the edits that were proposed here.