SDL2: Limit DirectSound maximum sample rate#15267
Merged
icculus merged 1 commit intolibsdl-org:SDL2from Mar 26, 2026
Merged
Conversation
cuckydev
changed the title
cuckydev
force-pushed
the
fix-dsound-max-frequency-sdl2
branch
from
218a6c0 to
26e37f4
Compare
cuckydev
force-pushed
the
fix-dsound-max-frequency-sdl2
branch
from
26e37f4 to
6872c21
Compare
Collaborator
|
Thank you for jumping on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limits the maximum sample rate for DirectSound audio to DSBFREQUENCY_MAX, as otherwise the sound buffer will fail to be created (documented here, reported here).
The exact maximum frequency depends on the version of DirectSound being targeted, which is currently defined as DirectSound 8.0 in SDL2:
SDL/src/core/windows/SDL_directx.h
Line 94 in 3debb9e
This PR is the same as #15266 and #15265 from the SDL3 branch.