iOS: honor SDL_HINT_MAIN_CALLBACK_RATE via CADisplayLink - #16060
Open
voki-andreev-a wants to merge 2 commits into
Open
iOS: honor SDL_HINT_MAIN_CALLBACK_RATE via CADisplayLink#16060voki-andreev-a wants to merge 2 commits into
voki-andreev-a wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On iOS, main callbacks are driven by a
CADisplayLink, soSDL_HINT_MAIN_CALLBACK_RATEwas ignored (unlike the generic path, which paces withSDL_DelayPrecise).This change registers an
SDL_AddHintCallbackforSDL_HINT_MAIN_CALLBACK_RATEand, when a positive rate is set, applies it to the display link:preferredFrameRateRangeviaCAFrameRateRangeMake((rate * 2) / 3, rate, rate)preferredFramesPerSecondDefault behavior is unchanged when the hint is unset or
"0"(including the existing ProMotion high-refresh setup). The hint can still be changed at runtime.Note: the system may still choose a nearby supported frame rate (e.g. divisors of 60/120 Hz), as with other
CADisplayLinkpreferences.Existing Issue(s)
Fixes #15277