Add PGN Sharing to the Openings Explorer#2664
Add PGN Sharing to the Openings Explorer#2664r3econ wants to merge 6 commits intolichess-org:mainfrom
Conversation
| icon: const PlatformShareIcon(), | ||
| ), | ||
| SemanticIconButton( | ||
| semanticsLabel: context.l10n.mobileSharePositionAsFEN, |
There was a problem hiding this comment.
label is wrong now that the button opens the share menu
There was a problem hiding this comment.
@veloce, thanks for spotting it 🎣 It looks like we do not have anything generic that would fit here 🤔
For now, I hardcoded it to Share game and added a new translation string 59a5024.
Is this a chicken - egg problem, isn't it? I can't use the translation key via context.l10n.mobileShareGame yet; it has to be generated and pulled by the CI action first.
If my understanding is correct I suggest we merge the PR and I'll update the code to use the translation logic once the key gets generated
There was a problem hiding this comment.
@r3econ take a look here: https://github.com/lichess-org/mobile/blob/main/docs/internationalisation.md you can add it to the mobile.xml and then generate the files
There was a problem hiding this comment.
Perfect, @HaonRekcef thanks for the hint! I generated the files ☑️ @veloce, the PR is ready 🚀
…rove-sharing-of-the-opening-position- # Conflicts: # lib/src/view/explorer/opening_explorer_screen.dart
|
Mmh actually we maybe could also use share and export like we do in the analysis board so we do not need a new translation |
|
One extra translation key is just a tip of an iceberg. IMHO, what we need is a broader refactor of game sharing functionality - having one easily reusable component that would allow for sharing:
Obviously, out of scope of this PR 🤔 |
|
Yes as said by HaonRekcef let's not add a new translation if we can avoid it (as it takes people time to translate). So please remove the string in mobile.xml and use the available |
3 participants
Demo