-
Notifications
You must be signed in to change notification settings - Fork 108
feat(EXP-428): add SupersetFacet v1.0.0 [GenericErrors v1.0.4, SupersetFacet v1.0.0, IOmniTokenAddressBook v1.0.0, ISupersetHubPoolManager v1.0.0, ISupersetPoolManager v1.0.0, ISupersetSpokePoolManager v1.0.0] #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
7c2a01b
feat(superset): add SupersetFacet v1.0.0
gvladika 4290e48
refactor(superset): unify hub + spoke into single facet with chain-id…
gvladika f5c0580
chore(superset): simplify demo to hardcoded params, no protocol details
gvladika 6589815
refactor(superset): drop native source asset support
gvladika 6cd8fec
refactor(superset): refund source-side native + leftovers to refundAd…
gvladika 990b349
refactor(superset): enforce lzFee sufficiency in shared validation
gvladika cd081c2
refactor(superset): facet cleanup — named args + tighter error model
gvladika 9ca0cb2
refactor(superset-demo): organize as scenario record + CLI flag
gvladika 79afee0
refactor(superset-demo): quote ETH→USDC pre-swap at runtime via Unisw…
gvladika 191494c
refactor(superset-demo): switch w-swap scenario to WETH→exact-USDC vi…
gvladika 714942d
chore(superset-demo): record executed-run tx hashes + clean-EOA fallback
gvladika 272663a
pr-ready: remove stale Non-EVM Destinations section (docs/SupersetFac…
gvladika 3cd6bb9
pr-ready: add destination-call rejection test (test/solidity/Facets/S…
gvladika 14bcd44
refactor(superset-test): exercise the real Base spoke instead of a mock
gvladika d8a7ad4
feat(SupersetFacet): add chainId↔lzEid mapping with destination valid…
gvladika a45effd
pr-ready: fix hub refundAddress guidance (docs/SupersetFacet.md:97)
gvladika 2e15237
pr-ready: reject empty supersetData.path early (src/Facets/SupersetFa…
gvladika 254b353
pr-ready: comment test-only inputToken extraction (test/solidity/Face…
gvladika 37ad6c4
pr-ready: unit-test amountOutMin positive-slippage math (test/solidit…
gvladika fe17c14
refactor(SupersetFacet): drop the lzEid+1 offset
gvladika 704fdc5
refactor(SupersetFacet): drop unsetChainIdToEid
gvladika 8327426
refactor(SupersetFacet): use InvalidConfig for destinationChainId↔toE…
gvladika 974f939
refactor(superset-test): replace mock spoke with vm.mockCall/expectCall
gvladika 0c325df
refactor(SupersetFacet): collapse _chainIdToEid into public getChainI…
gvladika 6944bd5
Update staging logs
gvladika fb35b41
Update demo script reference TXs
gvladika 026c6ef
chore(clear-signing): regenerate after adding SupersetFacet
gvladika 2201082
refactor(SupersetFacet): use standard for-loop increment
gvladika f007ded
docs(superset-interfaces): drop private-repo URL from NatSpec
gvladika e65b56b
Update deployment logs
gvladika 621f5df
pr-ready: align doc with InvalidConfig revert (docs/SupersetFacet.md:52)
gvladika 18ec27a
pr-ready: clarify hub-vs-spoke refundAddress semantics (src/Facets/Su…
gvladika f31fe09
pr-ready: cover setChainIdToEid update path (test/solidity/Facets/Sup…
gvladika b8d0777
Merge branch 'main' into worktree-superset-tech-assessment
gvladika 7c23053
pr-ready: clarify initSuperset is a diamondCut one-shot (docs/Superse…
gvladika f186e4d
pr-ready: fast-fail on stale deadline at source (src/Facets/SupersetF…
gvladika 1793a6a
pr-ready: drop Superset testnet config (config/superset.json:3)
gvladika ec6566a
pr-ready: emit per-entry ChainIdToEidSet in initSuperset (src/Facets/…
gvladika 5ddd19c
pr-ready: clarify amountOutMin vs amountOutMinPercent (src/Facets/Sup…
gvladika 49e6e86
pr-ready: document EIP-7702 fallbackEoA limitation (docs/SupersetFace…
gvladika 57a2bee
pr-ready: switch to absolute-amount positive-slippage scaling (src/Fa…
gvladika d597a34
pr-ready: collapse DeadlineExpired into InvalidConfig (src/Facets/Sup…
gvladika 04f003d
pr-ready: note EIP-7702 limitation on fallbackEoA param (src/Facets/S…
gvladika df89f3f
Merge remote-tracking branch 'origin/main' into worktree-superset-tec…
gvladika c5c35a0
chore(demo): refresh Superset quote values and exercise positive-slip…
gvladika 4fa6aed
chore(superset): repin SupersetFacet on staging + refresh demo for po…
gvladika 1e7b135
chore(superset): document source for PoolManager addresses
gvladika 3b2df2b
refactor(errors): add DeadlineExpired for in-flight timeout reverts
gvladika 6baa3f1
Merge remote-tracking branch 'origin/main' into worktree-superset-tec…
gvladika 75c67ac
Merge remote-tracking branch 'origin/main' into worktree-superset-tec…
0xDEnYO 070e2bb
fix(SupersetFacet): bind path input token to bridgeData.sendingAssetId
gvladika bfd3488
fix(SupersetFacet): reject zero amountOutMin slippage floor
gvladika 2c0e442
fix(SupersetFacet): reject zero chainId/lzEid in admin config
gvladika 2a6f8f3
docs(SupersetFacet): note amountOutMin scaling is conservative
gvladika 02191ea
fix(SupersetFacet): use solady mulDiv for amountOutMin scaling
gvladika 57c5169
Merge branch 'main' into worktree-superset-tech-assessment
gvladika 865f12e
chore(clear-signing): regenerate proposal after main merge
gvladika 6e741ed
chore(audit): add SupersetFacet v1.0.0 security review (Sujith Somraaj)
gvladika File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "IMPORTANT DEV NOTICE": "after adding a new mapping, call initSuperset (first deploy) or setChainIdToEid (incremental update) on every diamond where SupersetFacet is deployed", | ||
| "Source for LayerZero EIDs: https://docs.layerzero.network/v2/deployments/deployed-contracts": {}, | ||
| "Source for Superset PoolManager addresses: https://github.com/superset-finance/deployments/blob/main/manifests/mainnet.json": {}, | ||
| "poolManager": { | ||
| "arbitrum": "0xcC687ed9155F5e49719D5f3147F79FD5F177961c", | ||
| "base": "0x57C155a15a9CA0A6C1F759ac6988b4fCa3663Ea4", | ||
| "unichain": "0x326D0B0357b394EC5bbeFE87554243E5dc76e56E" | ||
| }, | ||
| "mappings": [ | ||
| { "chainId": 42161, "lzEid": 30110 }, | ||
| { "chainId": 8453, "lzEid": 30184 }, | ||
| { "chainId": 130, "lzEid": 30320 } | ||
| ] | ||
|
mirooon marked this conversation as resolved.
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.