Prepare lightning-node-connect for v0.3.7-alpha#124
Open
ViktorT-11 wants to merge 3 commits into
Open
Conversation
ellemouton
approved these changes
Apr 2, 2026
jamaljsr
reviewed
Apr 2, 2026
Member
There was a problem hiding this comment.
I tried to run this locally using Terminal but ran into an issue. The wasm panics when calling litrpc.Status.SubServerStatus, so I'm unable to get past the pairing page. I also tried using make example-server in this repo and got the same error when calling that RPC.
Browser logs:
2026-04-02 08:20:31.666 [DBG] WASM: WASM client ready for connecting
2026-04-02 08:20:32.193 [DBG] MBOX: (client) Dialing...
2026-04-02 08:20:32.194 [DBG] MBOX: (client) New conn, read_stream=60f7f18dfa68f90a447eba6adac58a4d277b5132d5b7316dca5e2b2378649033eb3d8b4926188b18a06b4d83d823444233accb52f097eac0d92a5dacec3bbf76, write_stream=60f7f18dfa68f90a447eba6adac58a4d277b5132d5b7316dca5e2b2378649033eb3d8b4926188b18a06b4d83d823444233accb52f097eac0d92a5dacec3bbf77
2026-04-02 08:20:32.195 [DBG] MBOX: (client) Attempting to create send socket/stream
2026-04-02 08:20:32.219 [DBG] MBOX: (client) Connected to send socket/stream
2026-04-02 08:20:32.245 [DBG] MBOX: (client) Receive mailbox initialized
2026-04-02 08:20:32.251 [DBG] MBOX: Starting client handshake
2026-04-02 08:20:32.991 [DBG] MBOX: Kicking off client handshake with client_key=03997ba0e47836b51d6916bdb605ae1ec33e8f2b291ef52effe54d413f84d97b59
2026-04-02 08:20:33.001 [DBG] MBOX: Completed client handshake with with server_key=029aebd6ff3ecba09ef882521c54769a36ccc0b569dd54421629b7bc438fcde262
2026-04-02 08:20:33.010 [DBG] WASM: WASM client connected to RPC
2026-04-02 08:20:33.198 [INF] WASM: Calling 'lnrpc.Lightning.GetInfo' on RPC with request {}
2026-04-02 08:20:33.231 [INF] WASM: Calling 'litrpc.Status.SubServerStatus' on RPC with request {}
panic: not supported
goroutine 47 [running]:
google.golang.org/protobuf/internal/impl.Export.MessageStateOf({}, {0x42c860, 0x3a035c0})
google.golang.org/protobuf@v1.36.11/internal/impl/pointer_reflect.go:198 +0x2
github.com/lightninglabs/lightning-terminal/litrpc.(*SubServerStatusReq).Reset(0x3a035c0)
github.com/lightninglabs/lightning-terminal/litrpc@v1.0.5/lit-status.pb.go:33 +0x8
google.golang.org/protobuf/proto.Reset({0x96b5c0, 0x3a035c0})
google.golang.org/protobuf@v1.36.11/proto/reset.go:18 +0x9
google.golang.org/protobuf/encoding/protojson.UnmarshalOptions.unmarshal({{}, 0x0, 0x0, 0x0, {0x0, 0x0}, 0x0}, {0x39bffc8, 0x2, 0x8}, ...)
google.golang.org/protobuf@v1.36.11/encoding/protojson/decode.go:75 +0x2
google.golang.org/protobuf/encoding/protojson.UnmarshalOptions.Unmarshal(...)
google.golang.org/protobuf@v1.36.11/encoding/protojson/decode.go:68
github.com/grpc-ecosystem/grpc-gateway/v2/runtime.decodeJSONPb(0x39c37c0, {{}, 0x0, 0x0, 0x0, {0x0, 0x0}, 0x0}, {0x42c860, 0x3a035c0})
github.com/grpc-ecosystem/grpc-gateway/v2@v2.22.0/runtime/marshal_jsonpb.go:222 +0xd
github.com/grpc-ecosystem/grpc-gateway/v2/runtime.unmarshalJSONPb({0x39bffb0, 0x2, 0x8}, {{}, 0x0, 0x0, 0x0, {0x0, 0x0}, 0x0}, ...)
github.com/grpc-ecosystem/grpc-gateway/v2@v2.22.0/runtime/marshal_jsonpb.go:207 +0xd
github.com/grpc-ecosystem/grpc-gateway/v2/runtime.(*JSONPb).Unmarshal(...)
github.com/grpc-ecosystem/grpc-gateway/v2@v2.22.0/runtime/marshal_jsonpb.go:167
github.com/lightninglabs/lightning-terminal/litrpc.RegisterStatusJSONCallbacks.func1({0x988158, 0x2d69280}, 0x3107408, {0x39bff88, 0x2}, 0x3a03590)
github.com/lightninglabs/lightning-terminal/litrpc@v1.0.5/status.pb.json.go:28 +0xb
main.(*wasmClient).InvokeRPC.func1()
github.com/lightninglabs/lightning-node-connect/cmd/wasm-client/main.go:375 +0x13
created by main.(*wasmClient).InvokeRPC in goroutine 11
github.com/lightninglabs/lightning-node-connect/cmd/wasm-client/main.go:361 +0xd
08:20:33.235 installHook.js:1 exit code: 2
overrideMethod @ installHook.js:1
exit @ _app-c326a93a41d544a1.js:2
runtime.wasmExit @ _app-c326a93a41d544a1.js:2
$func1290 @ lnc-pr-124.wasm:0x139215
$resume @ lnc-pr-124.wasm:0x18597b
08:20:33.236 _app-c326a93a41d544a1.js:2 Uncaught Error: Go program has already exited
at t._resume (_app-c326a93a41d544a1.js:2:175646)
at WebSocket.<anonymous> (_app-c326a93a41d544a1.js:2:175889)
t._resume @ _app-c326a93a41d544a1.js:2
(anonymous) @ _app-c326a93a41d544a1.js:2
08:20:33.236 _app-c326a93a41d544a1.js:2 Uncaught Error: Go program has already exited
at t._resume (_app-c326a93a41d544a1.js:2:175646)
at WebSocket.<anonymous> (_app-c326a93a41d544a1.js:2:175889)
t._resume @ _app-c326a93a41d544a1.js:2
(anonymous) @ _app-c326a93a41d544a1.js:2
08:20:33.236 _app-c326a93a41d544a1.js:2 Uncaught Error: Go program has already exited
at t._resume (_app-c326a93a41d544a1.js:2:175646)
at WebSocket.<anonymous> (_app-c326a93a41d544a1.js:2:175889)
t._resume @ _app-c326a93a41d544a1.js:2
(anonymous) @ _app-c326a93a41d544a1.js:2
08:20:33.236 _app-c326a93a41d544a1.js:2 Uncaught Error: Go program has already exited
at t._resume (_app-c326a93a41d544a1.js:2:175646)
at WebSocket.<anonymous> (_app-c326a93a41d544a1.js:2:175889)
t._resume @ _app-c326a93a41d544a1.js:2
(anonymous) @ _app-c326a93a41d544a1.js:2
08:20:34.219 _app-c326a93a41d544a1.js:2 Uncaught Error: Go program has already exited
at t._resume (_app-c326a93a41d544a1.js:2:175646)
at _app-c326a93a41d544a1.js:2:171780
t._resume @ _app-c326a93a41d544a1.js:2
(anonymous) @ _app-c326a93a41d544a1.js:2
ViktorT-11
changed the title
lightning-node-connect for v0.3.6-alphalightning-node-connect for v0.3.7-alpha
|
@ViktorT-11, remember to re-request review from reviewers when ready |
Bump lightninglabs/protobuf-go-hex-display to v1.36.11-hex-display. The upcomming commits will bump the litd dependencies throughout the repo, and with that change we'll need to use the new version of the hex display package, in order for our wasm package to be compatible with the new litd version.
Bump the dependencies to match the latest litd v0.16.1-alpha release.
Bump the dependencies to match the latest litd v0.16.1-alpha release.
ViktorT-11
force-pushed
the
2026-04-bump-litd-to-v0_16_1-alpha
branch
from
f4daf45 to
553c24e
Compare
ViktorT-11
commented
Jun 24, 2026
ViktorT-11
left a comment
ViktorT-11
left a comment
Contributor
Author
There was a problem hiding this comment.
After some digging, I realized that the issue we experienced previously in this PR is resolved by bumping our forked github.com/lightninglabs/protobuf-go-hex-display package to the version used in lnd.
| // allows us to specify that as an option. This is required for the | ||
| // taproot-assets dependency to function properly. | ||
| replace google.golang.org/protobuf => github.com/lightninglabs/protobuf-go-hex-display v1.34.2-hex-display | ||
| replace google.golang.org/protobuf => github.com/lightninglabs/protobuf-go-hex-display v1.36.11-hex-display |
Contributor
Author
There was a problem hiding this comment.
This change here should resolve the issues we noticed previously in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares
lightning-node-connectfor thev0.3.7-alpharelease.The PR bumps the litd dependencies in the
wasm-client&mobileto match the dependencies of litdv0.16.1-alpha.@jamaljsr, when you test this can you please specifically test passing
litcli&loopcommands over a session using the wasm-client? I'm having issues with that when testing locally, but I'm not sure if it's due to my local setup or if it's a specific issue introduced by this PR.