Skip to content

fix for PCRE2 find_package()#151

Open
pkleymonov-qnx wants to merge 2 commits intolighttpd:masterfrom
qnx-ports:pcre2_cmake_integration
Open

fix for PCRE2 find_package()#151
pkleymonov-qnx wants to merge 2 commits intolighttpd:masterfrom
qnx-ports:pcre2_cmake_integration

Conversation

@pkleymonov-qnx
Copy link
Copy Markdown
Contributor

Tries to find pcre2 with help of cmake native method: find_package()
it helps for cross-compilation and useful with conan package manger

@pkleymonov-qnx pkleymonov-qnx marked this pull request as ready for review February 2, 2026 14:46
@gstrauss
Copy link
Copy Markdown
Member

gstrauss commented Feb 3, 2026

Thank you for suggesting this PR.

Is this convention limited to finding pcre2, or is this applicable to other optional features in lighttpd?

@pkleymonov-qnx
Copy link
Copy Markdown
Contributor Author

Thank you for suggesting this PR.

Is this convention limited to finding pcre2, or is this applicable to other optional features in lighttpd?

Hi @gstrauss,

I made these changes because only WITH_PCRE2 and WITH_ZLIB are enabled by default.
For WITH_ZLIB = ON, lighttpd already handles this correctly using find_package(ZLIB).
The issue existed only with WITH_PCRE2, which is why I focused on that case.

As for the other options, I haven’t tested them yet, so I can’t say for sure whether switching them to find_package() would be straightforward or appropriate in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants