This repository was archived by the owner on Oct 28, 2025. It is now read-only.
feat(helm): add nodeSelector support to linkerd-failover#730
Open
bezarsnba wants to merge 1 commit intolinkerd:mainfrom
Open
feat(helm): add nodeSelector support to linkerd-failover#730bezarsnba wants to merge 1 commit intolinkerd:mainfrom
bezarsnba wants to merge 1 commit intolinkerd:mainfrom
Conversation
Signed-off-by: Beza <bezarsnba@gmail.com>
2f27563 to
5990704
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodeSelectorto thelinkerd-failoverchart. This allows users to specify which nodes in their Kubernetes cluster should be used to run thelinkerd-failoverpods.This is useful for scenarios where you want to:
linkerd-failoveron specific nodes with certain resources or hardware. For example, you might want to run it on nodes with more memory or specific hardware capabilities.linkerd-failoverpods from other workloads. This can be useful for security or performance reasons.The
nodeSelectoroption can be set in thevalues.yamlfile of the chart.Using
Users can utilize
NodeSelectorby setting the corresponding fields in thelinkerd-failovergraph values file:Tests:
This PR includes unit and integration tests to ensure that
NodeSelectorworks correctly. The tests were carried out in GKE.Output of kubectl apply: