ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Configure CI to run Ansible-based tests with facts not injected as variables by default.

CI:

• Set ANSIBLE_INJECT_FACT_VARS=false for qemu-kvm integration test workflow.
• Propagate Ansible fact injection setting into the tft CI workflow via SR_ANSIBLE_INJECT_FACT_VARS.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configure CI workflows to run Ansible with fact injection disabled by default so tests surface deprecation issues for fact-as-var usage, and propagate this setting into Terraform-based TFT runs.

Flow diagram for setting SR_ANSIBLE_INJECT_FACT_VARS in TFT CI job

flowchart TD
  A[GitHub PR opened or updated] --> B[GitHub Actions starts TFT workflow]
  B --> C[Run set_vars step to compute ARTIFACTS_DIR and ARTIFACTS_URL]
  C --> D[Compose Terraform env block in tft_yml]
  D --> E[Set SR_ANSIBLE_INJECT_FACT_VARS=false in env block]
  E --> F[Pass env block to Terraform TFT job]
  F --> G[Terraform invokes Ansible with ANSIBLE_INJECT_FACT_VARS=false]
  G --> H[Ansible emits warnings for deprecated fact-as-var usage]
  H --> I[CI surfaces deprecation issues in test results]

Loading

File-Level Changes

Change	Details	Files
Set ANSIBLE_INJECT_FACT_VARS=false in the QEMU/KVM integration GitHub Actions workflow so Ansible facts are not injected as top-level variables during CI runs.	Add ANSIBLE_INJECT_FACT_VARS environment variable with value "false" to the workflow job environment so all Ansible invocations in the job run with fact injection disabled	.github/workflows/qemu-kvm-integration-tests.yml
Propagate the Ansible fact injection setting into TFT-based system roles tests so Terraform-driven runs also disable fact-as-var injection.	Introduce SR_ANSIBLE_INJECT_FACT_VARS=false in the Terraform variables string passed to the TFT workflow so downstream jobs can consume this configuration consistently with other SR_* settings	.github/workflows/tft.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider aligning the variable naming by either reusing ANSIBLE_INJECT_FACT_VARS in the TFT workflow or adding a brief note on why SR_ANSIBLE_INJECT_FACT_VARS differs, to avoid confusion about which variable is actually consumed downstream.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider aligning the variable naming by either reusing `ANSIBLE_INJECT_FACT_VARS` in the TFT workflow or adding a brief note on why `SR_ANSIBLE_INJECT_FACT_VARS` differs, to avoid confusion about which variable is actually consumed downstream.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}