ci: skip most CI checks if title contains citest skip [citest_skip]#200
Merged
ci: skip most CI checks if title contains citest skip [citest_skip]#200
Conversation
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a conditional to multiple GitHub Actions workflows so that most CI jobs are skipped when a pull request title contains the marker string "[citest_skip]". File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Relying on a magic string in the PR title is a bit brittle and requires a force-push to change; consider using a dedicated label (e.g.
ci-skip) and checkinggithub.event.pull_request.labelsinstead so the behavior can be toggled without rewriting the title. - To make the condition safer if any of these workflows are ever triggered by events other than
pull_request, you may want to guard againstgithub.event.pull_requestbeing undefined, e.g.if: github.event_name != 'pull_request' || !contains(github.event.pull_request.title, '[citest_skip]').
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Relying on a magic string in the PR title is a bit brittle and requires a force-push to change; consider using a dedicated label (e.g. `ci-skip`) and checking `github.event.pull_request.labels` instead so the behavior can be toggled without rewriting the title.
- To make the condition safer if any of these workflows are ever triggered by events other than `pull_request`, you may want to guard against `github.event.pull_request` being undefined, e.g. `if: github.event_name != 'pull_request' || !contains(github.event.pull_request.title, '[citest_skip]')`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we submit a PR for a CI update or docs, we do not want to start CI checking
for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more
roles, this fires off a lot of unnecessary tests, which sometimes causes the
linux-system-roles org in github to be throttled.
When submitting a PR that can skip ci, use "[citest_skip]" in the PR title.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
CI: