ci: skip most CI checks if title contains citest skip [citest_skip]#202
Merged
ci: skip most CI checks if title contains citest skip [citest_skip]#202
Conversation
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideUpdate CI workflows to support skipping most checks when the PR title (or push commit message) contains the marker [citest_skip], and consolidate the skip condition logic across workflows. Sequence diagram for GitHub Actions job execution with citest_skipsequenceDiagram
actor Developer
participant GitHub as GitHub_Actions
participant Workflow as Workflow_job
Developer->>GitHub: Open_pull_request_or_push_commit
GitHub->>GitHub: Evaluate_event_name
alt Pull_request_event
GitHub->>GitHub: Check_PR_title_for_citest_skip
else Push_event
GitHub->>GitHub: Check_head_commit_message_for_citest_skip
end
alt Contains_citest_skip
GitHub-->>Developer: Mark_job_as_skipped
else Does_not_contain_citest_skip
GitHub->>Workflow: Start_job_execution
Workflow-->>Developer: Run_CI_checks
end
Flow diagram for CI job skip condition based on citest_skipflowchart TD
A[GitHub_event_received] --> B{event_name}
B -->|pull_request| C[Check_PR_title_for_citest_skip]
B -->|push| D[Check_head_commit_message_for_citest_skip]
C --> E{title_contains_citest_skip}
D --> F{message_contains_citest_skip}
E -->|yes| G[Set_job_condition_false_skip_job]
E -->|no| H[Set_job_condition_true_run_job]
F -->|yes| G
F -->|no| H
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The
[citest_skip]condition is duplicated verbatim across several workflows; consider extracting this into a reusable workflow or a shared expression (e.g., viaworkflow_callor a single called workflow) so future changes only need to be updated in one place. - In
woke.yml(and any other workflows that only trigger onpull_request), thepushbranch of theifcondition is never used, so you could simplify those specificifexpressions to only check the PR title for better readability. - You removed the explanatory comment in
ansible-lint.ymlbut added the same logic to other workflows without any explanation; consider keeping a brief inline comment near the first usage of this condition pattern to clarify its purpose for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `[citest_skip]` condition is duplicated verbatim across several workflows; consider extracting this into a reusable workflow or a shared expression (e.g., via `workflow_call` or a single called workflow) so future changes only need to be updated in one place.
- In `woke.yml` (and any other workflows that only trigger on `pull_request`), the `push` branch of the `if` condition is never used, so you could simplify those specific `if` expressions to only check the PR title for better readability.
- You removed the explanatory comment in `ansible-lint.yml` but added the same logic to other workflows without any explanation; consider keeping a brief inline comment near the first usage of this condition pattern to clarify its purpose for future maintainers.
## Individual Comments
### Comment 1
<location> `.github/workflows/woke.yml:7-11` </location>
<code_context>
- # do not run the pipeline if this is a pull request and the title contains [citest_skip],
- # or if this is a push and the head commit message contains [citest_skip]
ansible_lint:
if: |
!((github.event_name == 'pull_request' && contains(github.event.pull_request.title, '[citest_skip]')) ||
</code_context>
<issue_to_address>
**suggestion:** The `push` branch of the condition in this workflow appears unnecessary given it only triggers on `pull_request`.
Because this workflow only listens to `pull_request` events, `github.event_name` can never be `push` here, so that branch is dead code. Removing it will simplify the condition and avoid suggesting this workflow runs on pushes.
```suggestion
woke:
if: |
!(github.event_name == 'pull_request' && contains(github.event.pull_request.title, '[citest_skip]'))
name: Detect non-inclusive language
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we submit a PR for a CI update or docs, we do not want to start CI checking
for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more
roles, this fires off a lot of unnecessary tests, which sometimes causes the
linux-system-roles org in github to be throttled.
When submitting a PR that can skip ci, use "[citest_skip]" in the PR title.