ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]

[richm]

tox-lsr 3.17.1 has a fix for the broken container tests

There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.

Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.1 and ensure container integration tests always configure required Ansible plugins.

Build:

• Bump tox-lsr dependency from 3.17.0 to 3.17.1 in GitHub Actions workflows.

CI:

• Fix qemu-kvm integration workflow so container tests no longer skip callback/connection plugin setup across test runs.
• Correct indentation in the container support check within the qemu-kvm integration workflow.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.1, fixing broken container tests by ensuring connection plugins are always installed/used, and cleans up unnecessary skipping logic for callback/connection setup in qemu-kvm integration tests.

Sequence diagram for CI container tests with tox_lsr_3_17_1

sequenceDiagram
    actor Developer
    participant GitHub
    participant Workflow_ansible_test
    participant tox
    participant tox_lsr_3_17_1
    participant Ansible_container_tests

    Developer->>GitHub: Push commit / open PR
    GitHub->>Workflow_ansible_test: Trigger ansible-test workflow
    Workflow_ansible_test->>Workflow_ansible_test: pip install tox_lsr_3_17_1
    Workflow_ansible_test->>tox: Invoke tox for container tests
    tox->>tox_lsr_3_17_1: Load tox-lsr plugins and env
    tox_lsr_3_17_1->>tox_lsr_3_17_1: Install connection_plugin
    tox_lsr_3_17_1->>tox_lsr_3_17_1: Set ANSIBLE_CONNECTION_PLUGINS
    tox_lsr_3_17_1->>tox: Return configured env
    tox->>Ansible_container_tests: Run tests with connection plugin path set
    Ansible_container_tests-->>tox: Test results
    tox-->>Workflow_ansible_test: tox exit status
    Workflow_ansible_test-->>GitHub: Report CI status

Loading

File-Level Changes

Change	Details	Files
Update tox-lsr version used in GitHub Actions workflows to 3.17.1	Bump tox-lsr dependency from 3.17.0 to 3.17.1 in qemu-kvm integration tests workflow Bump tox-lsr dependency from 3.17.0 to 3.17.1 in ansible-lint workflow Bump tox-lsr dependency from 3.17.0 to 3.17.1 in ansible-managed-var-comment workflow Bump tox-lsr dependency from 3.17.0 to 3.17.1 in ansible-test workflow	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Adjust qemu-kvm integration workflow test loop to rely on tox-lsr 3.17.1 idempotent plugin setup and to avoid skipping connection/callback setup	Fix indentation of the yq-based containerbuild tag check to maintain valid shell syntax within the conditional Remove SKIP_CALLBACK_PLUGINS environment variable toggling before and within the test loop so callback and connection plugin setup is always executed	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}