Skip to content

Conversation

@paulfouquet
Copy link
Contributor

@paulfouquet paulfouquet commented Jan 8, 2026

Motivation

When create-manifest is listing files containing % in their file name, for example s3://hydro-data-bucket-418528898914/Authoritative_Surveys/HS72-Processed/3_Processed/1_GSF_PROJECTS/HS72_Block A_GSF_Project/SD/HS72_A_95%_C.I_4m_40-110m.sd, the system fails with a URI malformed error. It expects the % to be followed by a double hex to code a special char.

The same issue happens with the copy command when the decoded URI is passed to the https://github.com/blacha/chunkd library.

Modifications

When the file name in the path returned by the file list component contains a % that is not a code, the percent sign should be encoded as %25 so when decoding the path it does transform it back to % as it should be.
Re-encode % to %25 in a place where the URI is stringified to be passed to a FSA to avoid the issue happening.

Verification

Unit tests, Argo Workflows

@paulfouquet paulfouquet requested review from a team as code owners January 8, 2026 23:21
@paulfouquet paulfouquet added the container Build a container from a pull request label Jan 8, 2026
@paulfouquet paulfouquet added container Build a container from a pull request and removed container Build a container from a pull request labels Jan 8, 2026
@paulfouquet paulfouquet self-assigned this Jan 8, 2026
@paulfouquet paulfouquet added container Build a container from a pull request and removed container Build a container from a pull request labels Jan 9, 2026
@paulfouquet paulfouquet added container Build a container from a pull request and removed container Build a container from a pull request labels Jan 12, 2026
@paulfouquet paulfouquet marked this pull request as draft January 12, 2026 22:26
@paulfouquet
Copy link
Contributor Author

We don't want to push this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

container Build a container from a pull request

Development

Successfully merging this pull request may close these issues.

1 participant