Add remaining available room options#161
Open
alan-george-lk wants to merge 4 commits into
Open
Conversation
alan-george-lk
requested review from
stephen-derosa and
xianshijing-lk
as code owners
ladvoc
reviewed
Jun 10, 2026
| std::optional<RtcConfig> rtc_config; | ||
|
|
||
| /// Number of retries for the initial room join after the first attempt. | ||
| std::uint32_t join_retries = 3; |
Contributor
There was a problem hiding this comment.
question: I wonder if this should delegate to Rust for default values? Advantage of this approach is it is visible to the C++ dev, disadvantage is C++ could have different defaults if this later changes on the Rust side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoomOptionsstruct)toProtohelper for the entire struct