Skip to content

Agent skill: add code-review skill for github copilot that can check for compliance with sundials style guide - #991

Open
balos1 wants to merge 6 commits into
developfrom
maint/code-review-skill
Open

Agent skill: add code-review skill for github copilot that can check for compliance with sundials style guide#991
balos1 wants to merge 6 commits into
developfrom
maint/code-review-skill

Conversation

@balos1

@balos1 balos1 commented Aug 16, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub Copilot “code-review” skill intended to guide SUNDIALS PR reviews against the project’s developer-guide requirements.

Changes:

  • Introduces a code-review skill checklist covering source-code and documentation compliance expectations.
  • Defines a recommended review comment format for reporting developer-guide violations.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/skills/code-review/SKILL.md Outdated
Comment thread .agents/skills/code-review/SKILL.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: balos1 <5669480+balos1@users.noreply.github.com>
Comment thread .agents/skills/code-review/SKILL.md
@gardner48 gardner48 changed the title agent skill: add code-review skill for github copilot that can check for compliance with sundials style guide Agent skill: add code-review skill for github copilot that can check for compliance with sundials style guide Aug 18, 2026

@Steven-Roberts Steven-Roberts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. The "Source Review Checklist" and "Documentation Review Checklist" summarize conventions already in the developer docs, so it we update the docs, we'll need to remember to update this. I wonder if a review would differ much if we removed those sections. Copilot is already instructed to review our docs.

@balos1

balos1 commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

This looks reasonable to me. The "Source Review Checklist" and "Documentation Review Checklist" summarize conventions already in the developer docs, so it we update the docs, we'll need to remember to update this. I wonder if a review would differ much if we removed those sections. Copilot is already instructed to review our docs.

Yeah having the checklists enumerated may not be necessary. I am going to remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants