Add tests for resources in structs #614
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o res-in-structs-tests
…o res-in-structs-tests
This was referenced Jan 7, 2026
farzonl
reviewed
Jan 7, 2026
| [[vk::binding(5)]] | ||
| A a1 : register(u5); | ||
|
|
||
| A a2; |
Member
Author
There was a problem hiding this comment.
Yes, I wanted to test implicit binding as well. I can add a comment.
farzonl
reviewed
Jan 7, 2026
Comment on lines
15
to
16
| float x = b1.Bufs[0][ID.x]; | ||
| float y = b1.Bufs[1][ID.x]; |
Member
There was a problem hiding this comment.
Your buffers are all ints whats the point of doing these floating point implicit casts when you are going to store it back as an int?
Member
Author
There was a problem hiding this comment.
I'll change these to int as well. I started with floats for everything and then switched to ints since it is easier to check the results.
farzonl
approved these changes
Jan 7, 2026
kmpeng
reviewed
Jan 7, 2026
Contributor
kmpeng
left a comment
kmpeng
left a comment
There was a problem hiding this comment.
LGTM, mostly just a few nits. I think you accidentally linked the wrong issue to close though
| E e; | ||
| StructuredBuffer<int> SrvBuf2; | ||
| RWBuffer<int> UavBuf2; | ||
| uint n; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds tests for resource inside used-defined structs and classes. It includes 4 variants:
Closes #368