Open
Conversation
Contributor
Reviewer's GuideUpdates all Together AI SVG logo components (brand, text, mono, and color icons) to the new rebranded artwork and primary color, including adjusting viewBox, vector paths, and primary color constant. Updated class diagram for Together icon components and style constantsclassDiagram
class TogetherStyle {
+string TITLE
+number COMBINE_TEXT_MULTIPLE
+number COMBINE_SPACE_MULTIPLE
+string COLOR_PRIMARY
+string AVATAR_BACKGROUND
}
class BrandColorIcon {
+Icon(size, style, rest)
+svg viewBox_0_0_105_24
+group_scaled_logo_paths
}
class BrandMonoIcon {
+Icon(size, style, rest)
+svg viewBox_0_0_105_24
+group_scaled_logo_paths_mono
}
class TextIcon {
+Icon(size, style, rest)
+svg viewBox_0_0_105_24
+group_scaled_text_logo_paths
}
class ColorIcon {
+Icon(size, style, rest)
+svg viewBox_0_0_24_24
+group_scaled_mark_color_paths
}
class MonoIcon {
+Icon(size, style, rest)
+svg viewBox_0_0_24_24
+group_scaled_mark_mono_paths
}
TogetherStyle <.. BrandColorIcon : uses TITLE
TogetherStyle <.. BrandMonoIcon : uses TITLE
TogetherStyle <.. TextIcon : uses TITLE
TogetherStyle <.. ColorIcon : uses TITLE
TogetherStyle <.. MonoIcon : uses TITLE
TogetherStyle <.. ColorIcon : uses COLOR_PRIMARY
TogetherStyle <.. MonoIcon : uses COLOR_PRIMARY
TogetherStyle <.. BrandColorIcon : uses COLOR_PRIMARY
TogetherStyle <.. BrandMonoIcon : uses COLOR_PRIMARY
TogetherStyle <.. TextIcon : uses COLOR_PRIMARY
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Member
|
👍 @Nutlope |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
Color.tsxyou removedfill="currentColor", which means the icon will no longer inherit color from the surrounding text/theme; consider whether this is intentional or if the new SVG should still be themeable viacurrentColor. - The new SVGs use hard-coded
transformscales (e.g.,scale(0.12486)andscale(0.04949)); it may be worth extracting these into named constants or comments so future maintainers understand how these values were derived and can adjust them more safely. - The
viewBoxwidth change from116to105in the brand components can affect layout for consumers relying on the previous intrinsic aspect ratio—if the intent is to preserve sizing behavior, double-check that this new width matches how the logo is expected to render in existing UI contexts.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `Color.tsx` you removed `fill="currentColor"`, which means the icon will no longer inherit color from the surrounding text/theme; consider whether this is intentional or if the new SVG should still be themeable via `currentColor`.
- The new SVGs use hard-coded `transform` scales (e.g., `scale(0.12486)` and `scale(0.04949)`); it may be worth extracting these into named constants or comments so future maintainers understand how these values were derived and can adjust them more safely.
- The `viewBox` width change from `116` to `105` in the brand components can affect layout for consumers relying on the previous intrinsic aspect ratio—if the intent is to preserve sizing behavior, double-check that this new width matches how the logo is expected to render in existing UI contexts.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
Hi, my name is Hassan from Together AI. We recently went through a rebrand and I submitted this PR to update our logo. You can find more details about the rebrand and our latest brand assets at together.ai/brand. Thank you!
📝 补充信息 | Additional Information
Summary by Sourcery
Update Together AI branding assets across logo components to match the latest rebrand.
Bug Fixes:
Enhancements: