Fix bugs in if selections of fingerprint_file functions.#3
Open
ZaitianMou wants to merge 1 commit intolokifer:masterfrom
Open
Fix bugs in if selections of fingerprint_file functions.#3ZaitianMou wants to merge 1 commit intolokifer:masterfrom
ZaitianMou wants to merge 1 commit intolokifer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a small error in the fingperprint_file function of Fingerprinters.py.
In the selection, path_nodes is not used correctly, and program will go to the else block no matter what. This could cause some potentials cases where sites might need extra manipulation in else block or couldn't be fingerprinted at all.