feat: adding default compose template setting#922
Open
tdaron wants to merge 1 commit intolouislam:masterfrom
Open
feat: adding default compose template setting#922tdaron wants to merge 1 commit intolouislam:masterfrom
tdaron wants to merge 1 commit intolouislam:masterfrom
Conversation
7282278 to
2aefff1
Compare
2aefff1 to
7a81396
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tick the checkbox if you understand [x]:
Description
This adds a small setting to configure the default compose template used. I only saw the rules after making the changes locally, that's why I didn't opened a discussion as I already did it. Still ok if you don't want this feature :)
Without this feature, the default compose template is just a hardcoded constant in the code :(
Why would this feature be useful
In our infra, we have some network that every docker must be connected to, to be reachable from the reverse proxy. Would be very cool to be able to permanently add this network to the default template used.
Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)