fix: timers on STM32F411xE boards#138
Open
JeppeKlitgaard wants to merge 7 commits into
Open
Conversation
Added callback functionality to RotateControl
Add definition of static constexpr members
|
Hi @JeppeKlitgaard , would this also work on STM32F446ZET6? I would like to use this library on the BTT Octopus board. I want to know before I order it. |
Author
|
It might, but otherwise you can go through the relatively minor changes here and see if you can make any potentially required changes for your board. It should be similar enough that any required fixes are relatively minor. |
|
Well, it compiled successfully on a platformIO project which I chose that board for and added this lib as a dependency. Does that mean I’m good to go? |
Author
|
I don't believe that this necessarily is enough to prove that it would work, but it is a good start. The maintainer of the project might be able to help you better, otherwise I would encourage you just to tinker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
TimerFieldforSTM32F411xEboards such as the Nucleo F411RE board.It preserves compatibility with the existing supported board (
STM32F429xx) and introduces an error for boards that haven't been explicitly defined as working. Adding new boards is easy - simply look up the timers in the documentation and add the appropriate define clause.Note that I have not run tests on
STM32F429xx's, as I don't have access to any. @ramboerik if you still have the hardware and feel like it, it would be fantastic if you could confirm that this works for your setup.