pe: wrap ResourceData parse in or_permissive_and_default (follow-up to #508)#526
Open
CalebFenton wants to merge 2 commits intom4b:masterfrom
Open
pe: wrap ResourceData parse in or_permissive_and_default (follow-up to #508)#526CalebFenton wants to merge 2 commits intom4b:masterfrom
CalebFenton wants to merge 2 commits intom4b:masterfrom
Conversation
Follow-up to m4b#508 which added permissive support inside ResourceData::parse_with_opts but missed the top-level call site in PE::parse(). Without this, ParseMode::Permissive still fatally rejects PEs with malformed resource sections (e.g., packed malware where the packer mangled RT_VERSION RVAs). Matches the pattern used by every other data directory parse: debug_data, tls_data, load_config_data, clr_data, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #508. That PR added
or_permissive_and_defaultinsideResourceData::parse_with_optsbut the call site inPE::parse()still uses bare?:When
VersionInfo::parseorManifestData::parsefails inside that call (e.g. resource data RVAs that can't be mapped to file offsets), the error propagates through the bare?and kills the entire PE parse — even inParseMode::Permissive.This wraps it in
.map(Some).or_permissive_and_default(...), same as the debug_data, tls_data, load_config_data, and clr_data call sites nearby.We hit this on packed PE malware (FSG, TELock) where the packer mangles the resource section but the rest of the PE is fine.